Skip to content

[WIP] Replace progress APIs in favor of elapsed APIs - #38

Closed
SUPERCILEX wants to merge 27 commits into
djeedai:mainfrom
SUPERCILEX:elapsed
Closed

[WIP] Replace progress APIs in favor of elapsed APIs#38
SUPERCILEX wants to merge 27 commits into
djeedai:mainfrom
SUPERCILEX:elapsed

Conversation

@SUPERCILEX

@SUPERCILEX SUPERCILEX commented Aug 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #42, fixes #31.

SUPERCILEX added 17 commits May 29, 2022 22:10
@SUPERCILEX
Move towards more flexible animation looping
9288b0f 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Don't use nightly stuff
30b077a 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into loop
c01b3ea 
# Conflicts:
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Get rid of is_looping and finish implementing stuff
3df8870 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Reformat all comments using rustfmt
4e15064 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'comments' into loop
31ef21f 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>

# Conflicts:
#	examples/sequence.rs
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Final cleanup
178db98 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into loop
351c180 
# Conflicts:
#	examples/sequence.rs
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Tidy
e119f73 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Use repeat and mirrored repeat terminology
2f96f06 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Scootch duration to a place that makes more sense
90bd931 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into loop
7e2aac1 
# Conflicts:
#	examples/sequence.rs
#	src/tweenable.rs
@SUPERCILEX
Start implementing plan
af67aaa 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix very odd failure that doesn't occur on nightly
74a79cc 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Remove debug statement
595c2f9 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Address feedback
035c8cc 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Progress
ed9b383 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@djeedai djeedai mentioned this pull request Aug 3, 2022
Merged
@djeedai djeedai added the enhancement New feature or request label Aug 3, 2022
This was referenced Aug 4, 2022
Closed
Closed
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into elapsed
d3f208d 
# Conflicts:
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Add back bad merge stuff
d098f83 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix broken code
2212592 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Progress
cf7bdb9 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Blah
5691216 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX

SUPERCILEX commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

@djeedai this needs #37 (and #44 if that goes through) to be done right. Once I have the new testing framework I'll wrap up the sequence elapsed implementation.

@SUPERCILEX
Finish implementation
96cab31 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX

SUPERCILEX commented Aug 6, 2022

Copy link
Copy Markdown
Contributor Author

@djeedai this should be ready to go implementation wise! I'm waiting on #37 to write proper tests (which is waiting on the reverted commits being restored).

@djeedai

djeedai commented Aug 6, 2022

Copy link
Copy Markdown
Owner

Re-reverted, all commits are back :)

@SUPERCILEX

SUPERCILEX commented Aug 6, 2022

Copy link
Copy Markdown
Contributor Author

Sweet! I updated #37 and #44.

@SUPERCILEX SUPERCILEX mentioned this pull request Aug 10, 2022
Open
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into elapsed
a1352ec 
# Conflicts:
#	src/lib.rs
@SUPERCILEX
Fix bad merge
ce32b99 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Get rid of progress state in favor of computing it on-the-fly
fa4463f 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix
115fe63 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX SUPERCILEX mentioned this pull request Sep 20, 2022
Open
@djeedai

djeedai commented Oct 21, 2025

Copy link
Copy Markdown
Owner

Closing as Obsolete, this has been fixed.

@djeedai djeedai closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repeat broken after first iteration Get rid of progress and times_completed (well keep an ext trait with it around) in favor of elapsed

2 participants

@SUPERCILEX @djeedai