Updated to Bevy 0.19. - #171
Closed
Cyannide wants to merge 1 commit into
Closed
Conversation
The fix that needs a review is the change detection for Assets especially to make colormaterial_color functional.
Author
|
#170 the colormaterial_color example will not work because there is no AssetEvent::Modified triggered to push the material update to the GPU. |
Author
|
Also fixes #169 |
djeedai
reviewed
Jun 27, 2026
| else { | ||
| world.resource_scope::<Assets<A>, _>(|world, mut assets: Mut<Assets<A>>| { | ||
| // get_mut with into_inner() triggers AssetEvent::Modified | ||
| // essential for the render pipeline to re-upload to GPU |
Owner
There was a problem hiding this comment.
Essential but completely breaking the design which carefully avoids marking assets as changed all the way through to Lens::lerp(). This change unconditionally marks the asset modified, whether or not it's actually animated. See my fix on #170.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix that needs a review is the change detection for Assets especially to make colormaterial_color functional.