Implement "glue" for prover modules over koalabear field (old) - #4
Closed
OmegaTymbJIep wants to merge 11 commits into
Closed
Implement "glue" for prover modules over koalabear field (old)#4OmegaTymbJIep wants to merge 11 commits into
OmegaTymbJIep wants to merge 11 commits into
Conversation
## Changes Added comprehensive implementation of flatten column functionality to handle limb data in a circuit: 1. Created new `FlattenColumn` component in `common` package that: - Manages flattened limbs and mask columns - Implements projection constraints to verify data consistency - Supports reuse across multiple circuits to avoid duplication 2. Refactored EC arithmetic modules to use shared flatten column: - Updated ECADD and ECMUL to use common implementation - Added proper column sharing between circuits - Improved variable naming for clarity
1. Flatten columns for limbs and circuit masks were used in the modexp module for both 256-bit and 4096-bit instances. 2. Updated modexp constraints for a limbs column divided into 8 smaller columns.
|
The PR is good, everything seems to make sense to me. Only had 2 suggestions. |
## Changes 1. Use Flatten column in the ecpair module for a Plonk in Wizard part. 2. Adjust constraints for 8 columns of 16 bits. 3. Change the G2GroupCheckInstance.IsSuccess, so it uses 8 field values to represent the boolean, but the first 7 are empty.
Nazarevsky
force-pushed
the
feature/prover-over-koalabear
branch
from
May 16, 2025 15:25
792fb64 to
ed3f759
Compare
* Make 16 bit limbs for address * Make 16 bit limbs for txn signature * Rewrite ecdata for 16 bit limbs * Apply 16 bit divisions for unaligned data * Fix address constrains, remove unused variables * Break into 16 bit limbs * Refactor constant name and structures assignment * Refactor constant name and structures assignment * Fix divideBytes empty input function, add test * Fix wrong address trimming * Change reader to read antichamber csv file * Remove mocked data for modules that use hash module * Add working ecdsa module * Fix constraints and circuit * Apply constraint for an every column * Get rid of magic variables * Fix address constraint over all columns * Use constants from the common module * Change constants, change comments, bring commented constraints back * Add import for circuit * Change constant name, remove commented import * Fix ScanStreams, change limb size * Make constant global * Add left alignment for limbs * Add GnarkDataLA column * Uncomment projection query * Remove commented print, fix formatting * Rename DivideBytes into SplitBytes * Fix magic values * Change gnarkDataOffsetAlignment from bytes to bits
OmegaTymbJIep
changed the title
Author
|
Moved to #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
FlattenColumncomponent incommonpackage that:ecarith,modexp,ecpairChecklist