Skip to content

core: mark non-mutating methods as const #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dingusdev merged 1 commit into from
Aug 8, 2026
Merged

core: mark non-mutating methods as const #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/coresignal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class CoreSignal {
}

// Calls all connected slots.
void emit(Args... args) {
void emit(Args... args) const {
if (!_is_enabled) {
return;
}
Expand All @@ -77,7 +77,7 @@ class CoreSignal {
_is_enabled = true;
}

bool is_enabled() {
bool is_enabled() const {
return _is_enabled;
}

Expand Down
4 changes: 2 additions & 2 deletions core/timermanager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ typedef struct TimerInfo {
// Custom comparator for sorting our timer queue in ascending order
class MyGtComparator {
public:
bool operator()(const std::shared_ptr<TimerInfo>& l, const std::shared_ptr<TimerInfo>& r) {
bool operator()(const std::shared_ptr<TimerInfo>& l, const std::shared_ptr<TimerInfo>& r) const {
return l.get()->timeout_ns > r.get()->timeout_ns ||
(l.get()->timeout_ns == r.get()->timeout_ns && l.get()->id > r.get()->id);
}
Expand All @@ -128,7 +128,7 @@ class TimerManager {
}

// return current virtual time in nanoseconds
uint64_t current_time_ns() { return get_time_now(); }
uint64_t current_time_ns() const { return get_time_now(); }

// creating and cancelling timers
uint32_t add_absolute_timer(uint64_t timeout_ns, uint64_t interval, timer_cb cb);
Expand Down
Loading