Skip to content

Fix Mac OS 8.6 ATI Rage drawing artifacts #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dingusdev merged 3 commits into from
Aug 7, 2026
Merged

Fix Mac OS 8.6 ATI Rage drawing artifacts #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
025f0a0
atirage: Support solid and color host rectangle fills
mihaip Aug 7, 2026
a63513f
atirage: Support general-pattern source blits
mihaip Aug 7, 2026
0d533db
atirage: Handle SGRAM color register blits
mihaip Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 36 additions & 11 deletions devices/video/atimach64defs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@ enum {
ATI_PIX_FMT_ARGB8888 = 6,
};

/* Draw engine data-path values. */
enum {
ATI_DP_COLOR_SRC_BKGD_CLR = 0,
ATI_DP_COLOR_SRC_FRGD_CLR = 1,
ATI_DP_COLOR_SRC_HOST = 2,
ATI_DP_COLOR_SRC_BLIT = 3,
ATI_DP_MONO_SRC_ALWAYS_1 = 0,
ATI_DP_MIX_SRC = 7,
ATI_SRC_TRAJ_UNBOUNDED = 0,
ATI_SRC_TRAJ_PATTERN = 1,
ATI_SRC_TRAJ_ROTATED = 3,
};

/** Mach64 register offsets. */
enum {
ATI_CRTC_H_TOTAL_DISP = 0x000, // 0x0000
Expand Down Expand Up @@ -485,22 +498,30 @@ enum {
ATI_SRC_PITCH = 22, ATI_SRC_PITCH_size = 10,

ATI_SRC_X = 0x061, // 0x0184
ATI_SRC_X_pos = 0, ATI_SRC_X_size = 13,
ATI_SRC_X_pos = 0, ATI_SRC_X_size = 14,

ATI_SRC_Y = 0x062, // 0x0188
ATI_SRC_Y_pos = 0, ATI_SRC_Y_size = 15,

ATI_SRC_Y_X = 0x063, // 0x018C
ATI_SRC_WIDTH1 = 0x064, // 0x0190
ATI_SRC_WIDTH1_pos = 0, ATI_SRC_WIDTH1_size = 14,
ATI_SRC_HEIGHT1 = 0x065, // 0x0194
ATI_SRC_HEIGHT1_pos = 0, ATI_SRC_HEIGHT1_size = 15,
ATI_SRC_HEIGHT1_WIDTH1 = 0x066, // 0x0198
ATI_SRC_X_START = 0x067, // 0x019C
ATI_SRC_X_START_pos = 0, ATI_SRC_X_START_size = 14,
ATI_SRC_Y_START = 0x068, // 0x01A0
ATI_SRC_Y_START_pos = 0, ATI_SRC_Y_START_size = 15,
ATI_SRC_Y_X_START = 0x069, // 0x01A4
ATI_SRC_WIDTH2 = 0x06A, // 0x01A8
ATI_SRC_WIDTH2_pos = 0, ATI_SRC_WIDTH2_size = 14,
ATI_SRC_HEIGHT2 = 0x06B, // 0x01AC
ATI_SRC_HEIGHT2_pos = 0, ATI_SRC_HEIGHT2_size = 15,
ATI_SRC_HEIGHT2_WIDTH2 = 0x06C, // 0x01B0
ATI_SRC_CNTL = 0x06D, // 0x01B4
ATI_SRC_COLOR_REG_WRITE_EN = 13,
ATI_SRC_BLOCK_WRITE_EN = 14,
ATI_SCALE_OFF = 0x070, // 0x01C0
ATI_SCALE_WIDTH = 0x077, // 0x01DC
ATI_SCALE_HEIGHT = 0x078, // 0x01E0
Expand All @@ -509,6 +530,8 @@ enum {
ATI_SCALE_Y_INC = 0x07D, // 0x01F4
ATI_SCALE_VACC = 0x07E, // 0x01F8
ATI_SCALE_3D_CNTL = 0x07F, // 0x01FC
ATI_HOST_DATA0 = 0x080, // 0x0200
ATI_HOST_DATA15 = 0x08F, // 0x023C
ATI_HOST_CNTL = 0x090, // 0x0240
ATI_BM_HOSTDATA = 0x091, // 0x0244
ATI_BM_ADDR = 0x092, // 0x0248
Expand All @@ -520,10 +543,10 @@ enum {
ATI_PAT_CNTL = 0x0A2, // 0x0288

ATI_SC_LEFT = 0x0A8, // 0x02A0
ATI_SC_LEFT_pos = 0, ATI_SC_LEFT_size = 13,
ATI_SC_LEFT_pos = 0, ATI_SC_LEFT_size = 14,

ATI_SC_RIGHT = 0x0A9, // 0x02A4
ATI_SC_RIGHT_pos = 0, ATI_SC_RIGHT_size = 13,
ATI_SC_RIGHT_pos = 0, ATI_SC_RIGHT_size = 14,

ATI_SC_LEFT_RIGHT = 0x0AA, // 0x02A8

Expand Down Expand Up @@ -599,14 +622,16 @@ enum {
ATI_SRC_PATT_EN = 16, // VT/GT
ATI_SRC_PATT_ROT_EN = 17, // VT/GT
ATI_SRC_LINEAR_EN = 18, // VT/GT
ATI_SRC_LINE_X_DIR = 19, // VT/GT
ATI_SRC_TRACK_DST = 20, // VT/GT
ATI_PAT_MONO_EN = 23, // GT
ATI_PAT_CLR_4x2_EN = 24, // VT/GT
ATI_PAT_CLR_8x1_EN = 25, // VT/GT
ATI_HOST_BYTE_ALIGN = 26, // VT/GT
ATI_HOST_BIG_ENDIAN_EN = 28, // VT/GT
ATI_SRC_BYTE_ALIGN = 29, // VT/GT
ATI_SRC_BYTE_ALIGN = 19, // VT/GT
ATI_SRC_LINE_X_DIR = 20, // VT/GT
ATI_SRC_8x8x8_BRUSH = 21, // GT
ATI_FAST_FILL_EN = 22, // GT
ATI_SRC_TRACK_DST = 23, // VT/GT
ATI_PAT_MONO_EN = 24, // GT
ATI_PAT_CLR_4x2_EN = 25, // VT/GT
ATI_PAT_CLR_8x1_EN = 26, // VT/GT
ATI_HOST_BYTE_ALIGN = 28, // VT/GT
ATI_HOST_BIG_ENDIAN_EN = 29, // VT/GT

ATI_GUI_STAT = 0x0CE, // 0x0338
ATI_GUI_ACTIVE = 0,
Expand Down
Loading
Loading