clean up, complete and comment logistic regression example - #43
Merged
Conversation
benikm91
approved these changes
Jan 18, 2026
benikm91
left a comment
Collaborator
There was a problem hiding this comment.
I overall like the changes.
Why do you put the loss function into the BinaryLR object? For me the model and loss function should be separate concepts. As we can train a model on various loss functions and use a loss function on various models. For me, having a loss function on the model (or score like SKLearn) is a code smell. But for simple example does not matter.
Contributor
Author
|
There are two reasons, why combining the loss in the Logistic regression object might be justified:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I restructured and cleaned up the logistic regression example, with the intention of showcasing how simple applications are structured and the core components (like permutations, iterators, jit, ...) are used together.
Instead of relying on LinearMap, which is already a higher level abstraction.