Add better error messages if axis/axes are not part of tensor (#6). - #20
Merged
Conversation
Collaborator
Author
|
closes #6 |
benikm91
force-pushed
the
nice-error-messages
branch
2 times, most recently
from
January 1, 2026 19:40
b73a452 to
edbab14
Compare
marcelluethi
approved these changes
Jan 2, 2026
marcelluethi
left a comment
marcelluethi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for these changes. The code looks much cleaner now.
Good to merge, once the commented lines are removed.
| export dimwit.tensor.TupleHelpers.* | ||
| export dimwit.tensor.Join | ||
| export Prime.* | ||
| // Export type helpers TODO should these be exported? They are quite internal |
Contributor
There was a problem hiding this comment.
Should these be removed?
…his was combined with a clean up effort to allow for this. ShapeTypeHelpers are now type classes that combine common cases into a single type class. Zipvmap was cleaned up as old implementation from Gemini was weird.
benikm91
force-pushed
the
nice-error-messages
branch
from
January 2, 2026 17:10
edbab14 to
2fcf831
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main:
This was combined with a clean-up effort to enable it.
Additionally