Fixes drawer gone invisible on setup activity

[shubham1g5]

Product Description

I introduced an issue in #3747 where while trying to make setupActivity use the same drawer check as other screens, I unknowingly required PersonalID login for drawer to show up. Instead, SetupActivity should always show drawer even when the user is not logged into a PersonalID account.

Safety Assurance

Safety story

Small fix, updated tests to relflect the desired behaviour

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, RELEASES.md is updated accordingly
• Does the PR introduce any major changes worth communicating ? If yes, RELEASES.md is updated accordingly
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.80%. Comparing base (5af501e) to head (ce0c90a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3752      +/-   ##
============================================
- Coverage     24.80%   24.80%   -0.01%     
- Complexity     4253     4254       +1     
============================================
  Files           938      938              
  Lines         57220    57220              
  Branches       6847     6847              
============================================
- Hits          14194    14191       -3     
- Misses        41221    41224       +3     
  Partials       1805     1805              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 809995d9-7be1-474f-8b98-a995cd4360bf

📥 Commits

Reviewing files that changed from the base of the PR and between 3b36b92 and ce0c90a.

📒 Files selected for processing (5)

• app/src/org/commcare/activities/CommCareSetupActivity.java
• app/src/org/commcare/activities/LoginActivity.java
• app/src/org/commcare/activities/StandardHomeActivity.java
• app/src/org/commcare/navdrawer/BaseDrawerActivity.kt
• app/unit-tests/src/org/commcare/android/tests/personalid/PersonalIdDrawerVisibilityTest.kt

---

📝 Walkthrough

Walkthrough

This PR modifies drawer visibility logic to make it conditional on whether a personal ID login is required. The base class method shouldShowDrawerAfterCheck() accepts a new requirePersonalIDLogin parameter that allows callers to opt out of the logged-in-only requirement. Three activity subclasses pass the appropriate values: setup and login activities pass false/true respectively. Test coverage is updated to verify that the setup activity displays a drawer on Android 9+ even when not logged in.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• dimagi/commcare-android#3747: The main PR's drawer-visibility refactor in BaseDrawerActivity and updated shouldShowDrawer() calls (e.g., CommCareSetupActivity) builds directly on #3747's change to unify the setup-screen drawer check via shouldShowDrawerAfterCheck, adjusting how the drawer visibility decision is computed.

Suggested reviewers

• Jignesh-dimagi
• conroy-ricketts
• OrangeAndGreen

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main fix: addressing the drawer visibility issue on SetupActivity.
Description check	✅ Passed	The description covers the Product Description and Safety Assurance sections adequately, but is missing the Technical Summary section with rationale and design decisions.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ccct-2202_bump_device_compatibility_fix

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}