Make the create-credential auth WebView scrollable and full-height - #52
Open
nesfeder-proof wants to merge 1 commit into
Open
Conversation
The auth WebView was wrapped in a LazyColumn item with wrap-content height. The WebView collapses to its initial content height (leaving the sheet nearly empty), and the LazyColumn consumes vertical drag gestures, so pages taller than the viewport cannot be scrolled - interactive authorization flows get stuck on unreachable controls. Let the auth section fill the sheet and give the WebView the height remaining below the title, so it handles its own scrolling like a normal browser surface on any screen size. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth WebView was wrapped in a wrap-content LazyColumn item, which collapses it to its initial content height and swallows scroll gestures, so taller authorization pages get stuck with unreachable controls.
This lets the sheet fill the screen below the status bar and gives the WebView the remaining height, so pages scroll like a normal browser surface.