stop nan values in params showing as a problem instead invalid params

src/controllers/issueDetailsController.js

@@ -11,7 +11,7 @@ import { fetchOne } from '../middleware/middleware.builders.js'
 
 const validateParams = validateQueryParams({
   schema: v.object({
-    pageNumber: v.optional(v.pipe(v.string(), v.transform(parseInt), v.minValue(1)), '1')
+    pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.number(), v.integer(), v.minValue(1)), '1')
   })
 })
 

src/controllers/resultsController.js

@@ -555,7 +555,7 @@ export function getFileNameOrUrlAndCheckedTime (req, res, next) {
 
 const validateParams = validateQueryParams({
   schema: v.object({
-    pageNumber: v.optional(v.pipe(v.string(), v.transform(parseInt), v.minValue(1)), '1')
+    pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.number(), v.integer(), v.minValue(1)), '1')
   })
 })
 

src/middleware/dataset-failed-expectation-entry.middleware.js

@@ -41,7 +41,7 @@ const subPath = (organisation, dataset) => {
 export const validateExpectationParams = validateQueryParams({
   schema: v.object({
     expectation: ExpectationPathParams,
-    pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.minValue(1)), '1')
+    pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.number(), v.integer(), v.minValue(1)), '1')
   })
 })
 

src/middleware/dataview.middleware.js

@@ -32,7 +32,7 @@ import { splitByLeading } from '../utils/table.js'
 export const dataviewQueryParams = v.object({
   lpa: v.string(),
   dataset: v.string(),
-  pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.minValue(1)), '1'),
+  pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.number(), v.integer(), v.minValue(1)), '1'),
   resourceId: v.optional(v.string())
 })
 

src/middleware/entryIssueDetails.middleware.js

@@ -9,7 +9,7 @@ export const IssueDetailsQueryParams = v.object({
   dataset: v.string(),
   issue_type: v.string(),
   issue_field: v.string(),
-  pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.minValue(1)), '1'),
+  pageNumber: v.optional(v.pipe(v.string(), v.transform(s => parseInt(s, 10)), v.number(), v.integer(), v.minValue(1)), '1'),
   resourceId: v.optional(v.string())
 })
 

test/unit/middleware/dataviewQueryParams.test.js

@@ -0,0 +1,24 @@
+import { describe, it, expect } from 'vitest'
+import * as v from 'valibot'
+import { dataviewQueryParams } from '../../../src/middleware/dataview.middleware.js'
+
+// Regression: a non-numeric :pageNumber segment (e.g. /data/abc) used to parse
+// to NaN, slip past v.minValue(1), and crash later in getSetDataRange. The
+// schema now includes v.integer(), so invalid page numbers are rejected here.
+describe('dataviewQueryParams pageNumber', () => {
+  const base = { lpa: 'x', dataset: 'y' }
+
+  it('defaults to 1 when absent', () => {
+    expect(v.parse(dataviewQueryParams, base).pageNumber).toBe(1)
+  })
+
+  it('coerces a valid numeric string to a number', () => {
+    expect(v.parse(dataviewQueryParams, { ...base, pageNumber: '3' }).pageNumber).toBe(3)
+  })
+
+  // 'abc'/'' -> NaN; '0'/'-1' -> below the minimum. All must be rejected here
+  // rather than crashing downstream. (Note '2.5' parses to 2 and is valid.)
+  it.each(['abc', '', '0', '-1'])('rejects invalid pageNumber %j', (pageNumber) => {
+    expect(() => v.parse(dataviewQueryParams, { ...base, pageNumber })).toThrow()
+  })
+})