fix(cursor): SelectedImage blobIdWithData + JPEG soft-cap prep - #9834
Closed
yansigit wants to merge 0 commit into
Closed
fix(cursor): SelectedImage blobIdWithData + JPEG soft-cap prep#9834yansigit wants to merge 0 commit into
yansigit wants to merge 0 commit into
Conversation
Owner
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
2 similar comments
Owner
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
Owner
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
Owner
|
Obrigado pelo PR. Mantive a revisão de
|
yansigit
force-pushed
the
fix/cursor-selected-image-blobid
branch
from
August 9, 2026 03:51
7a0801e to
bc67eb4
Compare
Contributor
Author
|
@diegosouzapw Thanks. already done on our side:
|
diegosouzapw
force-pushed
the
fix/cursor-selected-image-blobid
branch
from
August 11, 2026 01:00
bc67eb4 to
5fd2325
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectedImagewithblob_id_with_data(field 9) +path, and store image bytes in the existing sessionblobStore(sha256 hex) so getBlob can hydrate vision the same way system-prompt roots already do. Legacy inline field 8 is no longer written.sharp(quality ladder + edge shrink), split inbound decode ceiling (16 MiB) from the 1 MiB wire cap, and fail closed on decode bombs / mislabeled JPEG / invalid base64.view_imagecaptions); this ports the wire-format + soft-cap pieces only (no Codex-only promote / multi-agent / MCP omit work).Related Issues
Validation
Choose the change type and focused loop from the
Contribution Golden Path. The full unit suite,
Vitest, the 60% coverage gate, and the production build all run in CI on this PR (#8329):
npm run lintFocused loop run locally:
All 28 tests in
cursor-image-input.test.tspassed.check:open-sse-typecheckOK (pre-existing baseline only). Lint green (pre-commit lint-staged + fullnpm run lint).Tests Added Or Updated
tests/unit/cursor-image-input.test.ts— field 9 / blobStore assertions; JPEG soft-cap + mislabeled PNG-as-JPEG + strict base64 + large-PNG resolve regressions.Coverage Notes
open-sse/utils/cursorAgentProtobuf.ts(encodeSelectedImageBody/encodeAgentRunRequest) andopen-sse/utils/cursorImages.ts(resolve + prep + sniff). Executor still passes the sameblobStoreinto encode; getBlob now also serves vision blobs stored during encode.Reviewer Notes
sharpdependency (^0.35.3; already present transitively / in overrides).CursorImageError.view_image.