fix(engine): blank output defaults to node id - #8
Merged
Merged
Conversation
Blank output_property wrote to occurrence UUID instead of graph node id, leaving orphan context keys. Affects workflow engine and node output docs. - Default blank/whitespace output_property to node id - Add regression tests for blank and whitespace cases - Document per-type node output shapes in fields.md - Add execution_config example to workflow.yaml - Add git discipline rule to AGENTS.md
|
⬆️ Go test coverage increased from 79.7% to 79.7% compared to 47f9050 (4 ignored files)
Updated Package Coverages: # Package Name | Prior | New
+ github.com/simpwf/workflow-engine/internal/workflow/engine | 77.8% | 78.2%View coverage for all packages# Package Name | Coverage
+ github.com/simpwf/workflow-engine/internal/workflow/engine | 78.2%
+ github.com/simpwf/workflow-engine/internal/workflow/executor | 86.7%
+ github.com/simpwf/workflow-engine/internal/workflow/handler | 92.6%
+ github.com/simpwf/workflow-engine/internal/workflow/inputtransport | 93.5%
+ github.com/simpwf/workflow-engine/internal/workflow/model | 89.6%
+ github.com/simpwf/workflow-engine/internal/workflow/repository | 75.8%
+ github.com/simpwf/workflow-engine/internal/workflow/service | 80.7%
+ github.com/simpwf/workflow-engine/internal/workflow/statusupdate | 82.1%
+ github.com/simpwf/workflow-engine/internal/workflow/transport | 11.6%
+ github.com/simpwf/workflow-engine/pkg/configuration | 90.8%
+ github.com/simpwf/workflow-engine/pkg/contextdiff | 56.0%
+ github.com/simpwf/workflow-engine/pkg/contextpath | 82.2%
+ github.com/simpwf/workflow-engine/pkg/database | 82.4%
+ github.com/simpwf/workflow-engine/pkg/ids | 87.5%
+ github.com/simpwf/workflow-engine/pkg/jsfunc | 75.0% |
Extend dev seed data to cover script nodes without explicit output_property, exercising blank-output default from prior engine fix. Affects seed workflow template and node definitions. - Add add-lucky-number script node definition - Link calculate-total to new node via next_node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blank output_property wrote to occurrence UUID instead of graph node id, leaving orphan context keys. Affects workflow engine and node output docs.