chore: remove the dead integrationTest source set and task - #296
Open
mlwelles wants to merge 1 commit into
Open
Conversation
The integrationTest source set and its Test task had never run anything, in four independent ways: - The configured source directory, src/integration-test/java, does not exist. - The task never calls useTestNG(), so it would default to JUnit 4 and run none of this project's TestNG tests even if sources appeared. - Its dependency configurations extend testCompile and testRuntime, both removed in Gradle 7. This project builds with Gradle 8.14.2. - Nothing wires the task into check, and CI runs `gradlew build`, which excludes it. Removing it also drops four no-op tasks that show up in `gradlew tasks` and suggest a working unit/integration split exists. Splitting the 19 cluster-dependent test classes out of src/test is still worth doing -- `gradlew test` cannot run without a live cluster today, which is awkward now that the suite has genuinely server-free tests. That needs scaffolding that works, so it belongs in its own change rather than being grafted onto this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
build.gradledeclares anintegrationTestsource set and a matchingTesttask. Neither has ever run anything. Four independent reasons, each sufficient on its own:src/integration-test/java, does not exist. Nor doessrc/integration-test/resources.task integrationTest(type: Test)never callsuseTestNG(). It would default to JUnit 4 and run none of this project's TestNG tests even if sources appeared.testCompileandtestRuntime, both removed in Gradle 7. This project builds with Gradle 8.14.2.check, and CI runs./gradlew build -i, which excludes it.Removing it also drops four no-op tasks from
./gradlew tasks(compileIntegrationTestJava,extractIntegrationTestProto,generateIntegrationTestProto,processIntegrationTestResources) plus theintegrationTesttask itself. Their presence suggests a working unit/integration split exists, which sends anyone looking for one down a dead end.What this does not do
Splitting the cluster-dependent tests out of
src/testis still worth doing. 19 of the 23 test classes need a live cluster, so./gradlew testcannot run without one — awkward now that the suite has genuinely server-free tests. That work needs scaffolding that functions, and it touches the CI workflow, so it belongs in its own change rather than being grafted onto a cleanup.Verification
./gradlew build -x testsucceeds../gradlew tasks --allno longer lists anyintegrationTesttask; nothing else references the source set.ExceptionMappingTest,RetryPolicyTest).No source or public API changes.
Checklist
CHANGELOG.mdfile describing and linking tothis PR
n/a, this removes build configuration and adds no behavior
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.