fix: skip out-of-range indexes in pull_at - #253
Merged
Conversation
Out-of-range or duplicate indexes made del raise IndexError. Skip indexes outside the array bounds so pull_at degrades like lodash.
Replace the isinstance/bounds continues with try/except IndexError so non-int indexes still TypeError and duplicate deletes soft-skip.
|
coverage: 100.0%. remained the same — santhreal:fix/pull-at-oob-index into dgilland:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pydash.arrays.pull_at hits IndexError when index past end of array. This PR fixes the regression with a focused test covering the case.