Skip to content

fix(docs): find the plugin checkout through herdr plugin list - #1136

Merged
devswha merged 1 commit into
mainfrom
fix/plugin-install-path
Oct 14, 2026
Merged

devswha merged 1 commit into
mainfrom
fix/plugin-install-path

Conversation

@devswha

@devswha devswha commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Change

herdr 0.9.4 moved GitHub plugin installs from plugins/github/<id>-<hash> to plugins/github-installations/<id>/<pid>-<n>/checkout (herdr src/plugin_paths.rs, herdr plugin update, herdrdev/herdr#4245). The ~/.config/herdr/plugins/github/devswha.herdr-web-ui-* glob in the guide's pairing command, INSTALL.md's status and pairing commands, and the docker fresh-install smoke therefore finds nothing on a current herdr.

They now read plugin_root from herdr plugin list --json, the same way install.sh already does, so the path is right on every herdr from 0.9.0. A changelog fragment is in changelog.d/plugin-root-from-herdr.md.

Validation

  • rg -n 'plugins/github/devswha' (excluding CHANGELOG.md): no matches.
  • Every documented root=$(...) line (guide.md, INSTALL.md x2) run as written on herdr 0.9.3 resolves to the installed checkout containing scripts/plugin.ts; bun "$root/scripts/plugin.ts" status prints running http://127.0.0.1:7317.
  • HERDR_TEST_MODE=unit bun test ./scripts/changelog-fold.test.ts ./scripts/conventions.test.ts: 21 pass, 0 fail.
  • bun scripts/fresh-install-docker.ts devswha/herdr-web-ui main (clean Ubuntu 24.04, herdr from herdr.dev, i.e. the 0.9.4+ layout): exit 0, including "a terminal through the sidecar, on the box's own Node" (PTY_OK through the new plugin_root path); no container left behind.

herdr 0.9.4 moved GitHub plugin installs from plugins/github/<id>-<hash>
to plugins/github-installations/<id>/<pid>-<n>/checkout, so the
plugins/github/devswha.herdr-web-ui-* glob in the guide, INSTALL.md and
the docker fresh-install smoke finds nothing on a current herdr.

Read plugin_root from herdr plugin list --json instead, as install.sh
already does; this works on every herdr from 0.9.0.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 12f77348-77c8-4b11-800f-a331455a42f1
📥 Commits

Reviewing files that changed from the base of the PR and between 525cdcf and 891529f.

📒 Files selected for processing: 4
  • INSTALL.md
  • changelog.d/plugin-root-from-herdr.md
  • docs/guide.md
  • scripts/fresh-install-docker.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated plugin status, pairing, and installation checks to locate plugin checkouts through Herdr, improving compatibility with Herdr 0.9.4 and later.

Installation instructions and Docker smoke tests now resolve the plugin checkout root from herdr plugin list --json. The instructions use that root for status and pairing commands. The smoke tests use it for both installation flows.

Changes: Plugin root resolution

Layer / File(s) Summary
Resolve and use the plugin root
scripts/fresh-install-docker.ts, INSTALL.md, docs/guide.md, changelog.d/plugin-root-from-herdr.md
The Docker smoke tests and pairing/status instructions use the plugin root reported by herdr instead of assuming a checkout under the old plugins directory. The changelog records that the commands support herdr 0.9.4 and later.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 89152

The updated instructions and smoke checks use a plugin-root field supported since herdr 0.9.0; no concrete merge-blocking risk was established.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (3 skipped: 3… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the primary change: resolving the plugin checkout through herdr plugin list.
Description check Passed The description includes the required Change and Validation sections. It explains the old-path failure, the new behavior, affected files, compatibility details, changelog entry, and validation results…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devswha

devswha commented Oct 14, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@devswha
devswha merged commit c67502d into main Oct 14, 2026
9 checks passed
@devswha
devswha deleted the fix/plugin-install-path branch October 14, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant