Repository navigation
fix(docs): find the plugin checkout through herdr plugin list - #1136
Conversation
herdr 0.9.4 moved GitHub plugin installs from plugins/github/<id>-<hash> to plugins/github-installations/<id>/<pid>-<n>/checkout, so the plugins/github/devswha.herdr-web-ui-* glob in the guide, INSTALL.md and the docker fresh-install smoke finds nothing on a current herdr. Read plugin_root from herdr plugin list --json instead, as install.sh already does; this works on every herdr from 0.9.0.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Change
herdr 0.9.4 moved GitHub plugin installs from
plugins/github/<id>-<hash>toplugins/github-installations/<id>/<pid>-<n>/checkout(herdrsrc/plugin_paths.rs,herdr plugin update, herdrdev/herdr#4245). The~/.config/herdr/plugins/github/devswha.herdr-web-ui-*glob in the guide's pairing command, INSTALL.md's status and pairing commands, and the docker fresh-install smoke therefore finds nothing on a current herdr.They now read
plugin_rootfromherdr plugin list --json, the same wayinstall.shalready does, so the path is right on every herdr from 0.9.0. A changelog fragment is inchangelog.d/plugin-root-from-herdr.md.Validation
rg -n 'plugins/github/devswha'(excluding CHANGELOG.md): no matches.root=$(...)line (guide.md, INSTALL.md x2) run as written on herdr 0.9.3 resolves to the installed checkout containingscripts/plugin.ts;bun "$root/scripts/plugin.ts" statusprintsrunning http://127.0.0.1:7317.HERDR_TEST_MODE=unit bun test ./scripts/changelog-fold.test.ts ./scripts/conventions.test.ts: 21 pass, 0 fail.bun scripts/fresh-install-docker.ts devswha/herdr-web-ui main(clean Ubuntu 24.04, herdr from herdr.dev, i.e. the 0.9.4+ layout): exit 0, including "a terminal through the sidecar, on the box's own Node" (PTY_OK through the newplugin_rootpath); no container left behind.