Skip to content

Commit 40e5805

Browse files
added nginx docker image
1 parent 1269116 commit 40e5805

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

e2e/tests/portforward/portforward.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,13 @@ var _ = DevSpaceDescribe("portforward", func() {
6969
done <- devCmd.RunDefault(f)
7070
}()
7171

72-
framework.ExpectRemoteCurlContents("ghcr.io/vaikunthawasi/portforward-ex", ns, "localhost:3000", "Hello World!")
73-
framework.ExpectLocalCurlContents("http://localhost:3000", "Hello World!")
72+
nginxResp := "<!DOCTYPE html>\n<html>\n<head>\n<title>Welcome to nginx!</title>\n<style>\nhtml { color-scheme: light dark; }\nbody { width: 35em; margin: 0 auto;\nfont-family: Tahoma, Verdana, Arial, sans-serif; }\n</style>\n</head>\n<body>\n<h1>Welcome to nginx!</h1>\n<p>If you see this page, the nginx web server is successfully installed and\nworking. Further configuration is required.</p>\n\n<p>For online documentation and support please refer to\n<a href=\"http://nginx.org/\">nginx.org</a>.<br/>\nCommercial support is available at\n<a href=\"http://nginx.com/\">nginx.com</a>.</p>\n\n<p><em>Thank you for using nginx.</em></p>\n</body>\n</html>"
73+
framework.ExpectRemoteCurlContents("nginx", ns, "localhost", nginxResp)
74+
framework.ExpectLocalCurlContents("http://localhost:3000", nginxResp)
7475

75-
framework.ExpectLocalCurlContents("http://localhost:8888", "Hello World!")
76-
framework.ExpectRemoteCurlContents("ghcr.io/vaikunthawasi/portforward-ex", ns, "localhost:8888", "Hello World!")
76+
httpServerResp := "Hello World!"
77+
framework.ExpectLocalCurlContents("http://localhost:8888", httpServerResp)
78+
framework.ExpectRemoteCurlContents("nginx", ns, "localhost:8888", httpServerResp)
7779

7880
cancel()
7981
err = <-done

e2e/tests/portforward/testdata/portforward-simple/devspace.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ deployments:
66
helm:
77
values:
88
containers:
9-
- image: ghcr.io/vaikunthawasi/portforward-ex
9+
- image: nginx
1010
# imagePullPolicy: Never
1111
dev:
1212
app:
13-
imageSelector: ghcr.io/vaikunthawasi/portforward-ex
13+
imageSelector: nginx
1414
ports:
15-
- port: "3000"
15+
- port: "3000:80"
1616
reversePorts:
17-
- port: "8888"
17+
- port: "8888:8888"

0 commit comments

Comments
 (0)