added e2e test for port forwarding and reverse forwarding

Author: tukobadnyanoba

e2e/e2e_suite_test.go

@@ -19,6 +19,7 @@ import (
 	_ "github.com/loft-sh/devspace/e2e/tests/imports"
 	_ "github.com/loft-sh/devspace/e2e/tests/init"
 	_ "github.com/loft-sh/devspace/e2e/tests/pipelines"
+	_ "github.com/loft-sh/devspace/e2e/tests/portforward"
 	_ "github.com/loft-sh/devspace/e2e/tests/proxycommands"
 	_ "github.com/loft-sh/devspace/e2e/tests/pullsecret"
 	_ "github.com/loft-sh/devspace/e2e/tests/render"

e2e/framework/helper.go

@@ -2,15 +2,15 @@ package framework
 
 import (
 	"fmt"
-	"io/ioutil"
-	"os"
-	"strings"
-	"time"
-
+	"github.com/go-resty/resty/v2"
 	"github.com/loft-sh/devspace/e2e/kube"
 	"github.com/onsi/gomega"
 	"github.com/pkg/errors"
+	"io/ioutil"
 	"k8s.io/apimachinery/pkg/util/wait"
+	"os"
+	"strings"
+	"time"
 )
 
 // ExpectEqual expects the specified two are the same, otherwise an exception raises
@@ -75,6 +75,30 @@ func ExpectRemoteFileContents(imageSelector string, namespace string, filePath s
 	ExpectNoErrorWithOffset(1, err)
 }
 
+func ExpectLocalCurlContents(urlString string, contents string) {
+	client := resty.New()
+	err := wait.PollImmediate(time.Second, time.Minute*2, func() (done bool, err error) {
+		resp, err := client.R().
+			EnableTrace().
+			Get(urlString)
+		return strings.TrimSpace(string(resp.Body())) == strings.TrimSpace(contents), nil
+	})
+	ExpectNoErrorWithOffset(1, err)
+}
+
+func ExpectRemoteCurlContents(imageSelector string, namespace string, urlString string, contents string) {
+	kubeClient, err := kube.NewKubeHelper()
+	ExpectNoErrorWithOffset(1, err)
+	err = wait.PollImmediate(time.Second, time.Minute*2, func() (done bool, err error) {
+		out, err := kubeClient.ExecByImageSelector(imageSelector, namespace, []string{"curl", urlString})
+		if err != nil {
+			return false, nil
+		}
+		return strings.TrimSpace(out) == strings.TrimSpace(contents), nil
+	})
+	ExpectNoErrorWithOffset(1, err)
+}
+
 func ExpectRemoteFileNotFound(imageSelector string, namespace string, filePath string) {
 	kubeClient, err := kube.NewKubeHelper()
 	ExpectNoErrorWithOffset(1, err)

e2e/tests/pipelines/pipelines.go

@@ -14,7 +14,7 @@ import (
 	"github.com/onsi/ginkgo"
 )
 
-var _ = DevSpaceDescribe("portforward", func() {
+var _ = DevSpaceDescribe("pipelines", func() {
 	initialDir, err := os.Getwd()
 	if err != nil {
 		panic(err)

e2e/tests/portforward/portforward.go

@@ -1,23 +1,83 @@
 package portforward
 
 import (
+	"context"
+	"fmt"
+	"github.com/loft-sh/devspace/cmd"
+	"github.com/loft-sh/devspace/cmd/flags"
+	"github.com/loft-sh/devspace/e2e/framework"
+	"github.com/loft-sh/devspace/e2e/kube"
+	"github.com/loft-sh/devspace/pkg/util/factory"
 	"github.com/onsi/ginkgo"
+	"net/http"
+	"os"
 )
 
 var _ = DevSpaceDescribe("portforward", func() {
-	ginkgo.It("should forward ports", func() {
-		// TODO
-	})
+	initialDir, err := os.Getwd()
+	if err != nil {
+		panic(err)
+	}
 
-	ginkgo.It("should restart port forwarding", func() {
-		// TODO
-	})
+	// create a new factory
+	var (
+		f          factory.Factory
+		kubeClient *kube.KubeHelper
+	)
+
+	ginkgo.BeforeEach(func() {
+		f = framework.NewDefaultFactory()
 
-	ginkgo.It("should reverse forward ports", func() {
-		// TODO
+		kubeClient, err = kube.NewKubeHelper()
+		framework.ExpectNoError(err)
+
+		go func() {
+			http.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) {
+				_, _ = fmt.Fprintf(w, "Hello World!")
+			})
+			fmt.Println("Server started at port 8888")
+			err := http.ListenAndServe(":8888", nil)
+			framework.ExpectNoError(err)
+		}()
 	})
 
-	ginkgo.It("should restart reverse forward ports", func() {
-		// TODO
+	ginkgo.It("should forward and reverse forward ports", func() {
+		tempDir, err := framework.CopyToTempDir("tests/portforward/testdata/portforward-simple")
+		framework.ExpectNoError(err)
+		defer framework.CleanupTempDir(initialDir, tempDir)
+
+		ns, err := kubeClient.CreateNamespace("portforward")
+		framework.ExpectNoError(err)
+		defer framework.ExpectDeleteNamespace(kubeClient, ns)
+
+		// create a new dev command and start it
+		done := make(chan error)
+		cancelCtx, cancel := context.WithCancel(context.Background())
+		defer cancel()
+
+		go func() {
+			defer ginkgo.GinkgoRecover()
+			devCmd := &cmd.RunPipelineCmd{
+				GlobalFlags: &flags.GlobalFlags{
+					NoWarn:     true,
+					Namespace:  ns,
+					ConfigPath: "devspace.yaml",
+				},
+				Pipeline: "dev",
+				Ctx:      cancelCtx,
+			}
+			done <- devCmd.RunDefault(f)
+		}()
+
+		framework.ExpectRemoteCurlContents("ghcr.io/vaikunthawasi/portforward-ex", ns, "localhost:3000", "Hello World!")
+		framework.ExpectLocalCurlContents("http://localhost:3000", "Hello World!")
+
+		framework.ExpectLocalCurlContents("http://localhost:8888", "Hello World!")
+		framework.ExpectRemoteCurlContents("ghcr.io/vaikunthawasi/portforward-ex", ns, "localhost:8888", "Hello World!")
+
+		cancel()
+		err = <-done
+		framework.ExpectNoError(err)
 	})
+
 })

e2e/tests/portforward/testdata/portforward-simple/devspace.yaml

@@ -0,0 +1,17 @@
+version: v2beta1
+name: portforward-ex
+
+deployments:
+  app:
+    helm:
+      values:
+        containers:
+          - image: ghcr.io/vaikunthawasi/portforward-ex
+#            imagePullPolicy: Never
+dev:
+  app:
+    imageSelector: ghcr.io/vaikunthawasi/portforward-ex
+    ports:
+      - port: "3000"
+    reversePorts:
+      - port: "8888"