feat(meerkat-core): recognise FROM-side column aliases (AS t(v), UNNEST, joins, VALUES) in the alias walker#296
Merged
Conversation
shashwat-devrev
requested review from
itsTalwar,
ujaval403,
vpbs2 and
zaidjan-devrev
as code owners
|
shriram-devrev
approved these changes
Jul 13, 2026
shashwat-devrev
changed the title
ujaval403
approved these changes
Jul 14, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://app.devrev.ai/devrev/issue/SURFF-1305
ensureParsedExpressionAliasprefixes bare column references with the owning table name so downstream binding is unambiguous under joins. Its scope-tracking set previously covered only lambda-bound identifiers. Anything else bare got rewritten. FROM-clause bindings(AS t(v)on subqueries,UNNEST(...) AS t(v), join binders, PIVOT, VALUES ... AS t(a, b, c), base-table column aliases) were invisible to the walker. Any bare identifier that matched a FROM-side alias got the outer-table prefix applied, turning valid SQL into a binder error.What is fixed?
Consumers emitting DuckDB SQL through meerkat can't safely use column-aliased FROM clauses. Concretely, the correlated-scalar-subquery pattern for aggregating an array-typed column:
(SELECT avg(v) FROM UNNEST(any_value(list_transform(surveys_aggregation, x -> x.average))) AS t(v))gets rewritten to:
(SELECT avg(ticket.v) FROM UNNEST(any_value(list_transform(surveys_aggregation, x -> x.average))) AS t(v))DuckDB then rejects:
Binder Error: Values list "ticket" does not have a column named "v"Relevant PR: #298 Bump meerkat node