Skip to content

feat: Add timestamps to artifacts and worker_metadata for easier tracking#210

Open
gasperzgonec wants to merge 19 commits into
mainfrom
gasperz/timestamps_merged
Open

feat: Add timestamps to artifacts and worker_metadata for easier tracking#210
gasperzgonec wants to merge 19 commits into
mainfrom
gasperz/timestamps_merged

Conversation

@gasperzgonec

Copy link
Copy Markdown
Contributor

Description

This PR merges PRs #202 and #205 together

Connected Issues

Checklist

  • Tests added/updated and ran with npm run test OR no tests needed.
  • Ran backwards compatibility tests with npm run test:backwards-compatibility.
  • Code formatted and checked with npm run lint.
  • Tested airdrop-template linked to this PR.
  • Documentation updated and provided a link to PR / new docs OR no docs needed.

@gasperzgonec gasperzgonec requested review from a team and radovanjorgic as code owners June 12, 2026 06:57
@gasperzgonec gasperzgonec force-pushed the gasperz/timestamps_merged branch from 41866b6 to 4d92e8d Compare June 12, 2026 08:14
Comment thread src/multithreading/worker-adapter/worker-adapter.ts Outdated
Comment thread src/types/extraction.ts
Comment thread src/repo/repo.ts
Comment thread src/repo/repo.ts Outdated
Comment thread src/multithreading/worker-adapter/worker-adapter.ts
Comment thread src/multithreading/worker-adapter/worker-adapter.ts Outdated
@gasperzgonec gasperzgonec force-pushed the gasperz/timestamps_merged branch from 8c1d0fa to 34d5fec Compare June 12, 2026 10:05

@radovanjorgic radovanjorgic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will approve once it is tested and verified by @gasperzgonec and @GasperSenk.

svc-devrev-sdk and others added 2 commits June 12, 2026 10:51
Resolve version conflicts by keeping branch beta version (1.19.9-beta.1)
while incorporating main's dependency updates.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File src/common/control-protocol.test.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.

@github-actions

Copy link
Copy Markdown

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File src/common/control-protocol.test.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.

Merges the Snyk-proposed upgrades from PRs #218 and #219.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File src/common/control-protocol.test.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.

@github-actions

Copy link
Copy Markdown

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File src/common/control-protocol.test.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.

@gasperzgonec gasperzgonec force-pushed the gasperz/timestamps_merged branch from 0c6068a to 4b27ca8 Compare July 14, 2026 08:09
@github-actions

Copy link
Copy Markdown

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File src/common/control-protocol.test.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.

},
worker_metadata: {
...worker_metadata,
newest_state_date: event.payload.event_context.extract_to,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to name these two values extract_from and extract_to or event_context_extract_from and ..._to just to be a bit more consistent? We started using 3 or 4 names for the similar value: last successful sync started, worker oldest/newest, extraction_start/end_time, extract_from/to and now also oldest/newest_state_date. It is really becoming hard to track what is what.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why we need these values here in worker_metadata if we can get it from the event context?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These worker_metadata fields are meant to be handled in the snapin-manager, and they should be formatted in a way that it can parse it.
I don't think snapin-manager can read from the event_context when we respond, and we just package content in there for the later processing on the platform.

Names have been set to what the platform expects.

Comment thread src/multithreading/worker-adapter/worker-adapter.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants