Sharpen inference benchmark presentation - #1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the repository’s landing-page presentation to be research-facing, highlighting the central KV-cache pressure result and providing a tighter map of the benchmark harness, methodology, and reproduction path.
Changes:
- Replaced the long chronological README with a concise overview centered on the canonical prefix-cache pressure experiment and matched control.
- Added benchmark controls, system design diagram, repository map, reproduction steps, canonical artifact links, and explicit scope/limitations.
- Updated the package description to reflect the current vLLM KV-cache / scheduling / serving focus.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Rewrites the landing page to foreground the main result, controls, architecture, and reproducibility/artifact entry points. |
| pyproject.toml | Updates the project description to match the repository’s current vLLM KV-cache/scheduling/serving benchmarking scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Latest extra-long follow-up: | ||
| [`results/prefix-cache-study-extra-long-merged-r8/key-results.md`](results/prefix-cache-study-extra-long-merged-r8/key-results.md) | ||
| The strongest server experiment uses `Qwen/Qwen2.5-1.5B-Instruct` on an NVIDIA L4 with 32 unique requests. The shared-prefix and matched unique-prefix workloads have comparable prompt shapes; the control contains no exact duplicate prompts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The underlying experiments are technically strong, but the previous landing page buried the central result beneath procedural history and repetitive artifact links. The new presentation makes the systems contribution and evidentiary boundaries legible to research-engineering reviewers without overstating generality.
Validation
python3 -m unittest discover -s tests(70 tests passed)git diff --check