Repository navigation
CI: fail on test failures and skip image push on pull requests - #1
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testwas followed by|| echo ..., so failing tests never failed the pipeline. The repo has a Vitest suite (src/__tests__/gameLogic.test.ts), so the fallback is removed.main. On pull requests the image is still built and scanned with Trivy, but nothing gets pushed (PRs don't have access to theTOKENsecret anyway).libexpatfrom thenginx:alpinebase image. AddedRUN apk upgrade --no-cacheto the nginx stage so the image picks up the fixed packages; the scan now passes.🤖 Generated with Claude Code