Repository navigation
AI, perf: optimize jar zip indexing, eliminate rwlock contention, and fix false positives - #4
Merged
Merged
Conversation
…tion targets and depth increment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
ZipArchive::newcalls inside rayonpar_iterwith single-pass memory extraction and parallel processing. scans that previously took 1.5+ minutes or timed out now finish in 0.6–2.2 seconds.RwLock<HashSet<String>>inSAFE_STRING_CACHEthat caused thread lock contention across worker threads.guess_reflected_targetthat treated any field name with length > 5 as a reflection target.archive_depth + 1inscan_nested_archive_buffer.benchmarks
CelestialBeta.jar(22 mb, ~19k entries): 1m 33s -> 0.61s (~150x faster)Relake.jar(44 mb, ~26k entries): timeout (>180s) -> 2.24s