Skip to content

Try <a>'ing links #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbelLykens wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Try <a>'ing links #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion www/webapp/src/views/CrudList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,15 @@
v-for="(column, id) in columns"
#[column.name]="itemFieldProps"
>
<router-link
v-if="cellUsesPlainText(column, rawItem(itemFieldProps.item)) && column.link"
:key="`${id}-link`"
class="crud-readonly-value crud-link"
:to="column.link(rawItem(itemFieldProps.item))"
@click.stop
>{{ readonlyDisplayValue(column, rawItem(itemFieldProps.item)) }}</router-link>
<div
v-if="cellUsesPlainText(column, rawItem(itemFieldProps.item))"
v-else-if="cellUsesPlainText(column, rawItem(itemFieldProps.item))"
:key="`${id}-readonly`"
class="crud-readonly-value"
v-text="readonlyDisplayValue(column, rawItem(itemFieldProps.item))"
Expand Down Expand Up @@ -841,6 +848,12 @@ export default {
min-height: 56px;
padding: 20px 0 4px;
}
/* a real link, so that it can be opened in a new tab, but looking like the rest
of the row (App.vue underlines it on hover, like any other link) */
.v-application a.crud-link {
color: inherit !important;
text-decoration: none;
}
</style>

<!-- Add "scoped" attribute to limit CSS to this component only -->
Expand Down
1 change: 1 addition & 0 deletions www/webapp/src/views/CrudListDomain.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export default {
writeOnCreate: true,
datatype: GenericText.name,
searchable: true,
link: item => ({name: 'domain', params: {domain: item.name}}),
},
published: {
name: 'item.published',
Expand Down