feat(tenant): add generate_sso_configuration_link to Tenant management

[dorsha]

Fixes descope/etc#15591

View workflow run

Perfect! I've updated the implementation to include all the missing parameters from the API specification. Here's what was changed:

🎯 Changes Made

Updated Method: generate_sso_configuration_link

New signature with all API parameters:

def generate_sso_configuration_link(
    self,
    tenant_id: Optional[str] = None,
    expire_time: Optional[int] = None,
    email: Optional[str] = None,        # ← NEW
    sso_id: Optional[str] = None,       # ← NEW
) -> str:

Key Updates:

1. Added Missing Parameters:

   • email - Email address associated with the admin
   • sso_id - SSO identifier for the tenant

2. Made All Parameters Optional:

   • tenant_id - Now optional (per API docs)
   • expire_time - Now optional (per API docs)

3. Enhanced Tests:

   • ✅ Test with all parameters
   • ✅ Test with minimal parameters (no args)
   • ✅ Test with original parameters (backward compatibility)
   • ✅ Test failure scenarios

📊 Quality Gate Results ✅

• Format: ✅ Passed (no changes needed)
• Lint: ✅ Passed (no issues)
• Typecheck: ✅ Passed (mypy clean)
• Tests: ✅ Passed (13/13 tenant tests, including 4 for this method)

💻 Usage Examples

from descope import DescopeClient

client = DescopeClient(project_id, management_key=mgmt_key)

# Minimal - all parameters optional
link = client.mgmt.tenant.generate_sso_configuration_link()

# With tenant and expiration
link = client.mgmt.tenant.generate_sso_configuration_link(
    tenant_id="tenant-123",
    expire_time=21600  # 6 hours
)

# With all parameters
link = client.mgmt.tenant.generate_sso_configuration_link(
    tenant_id="tenant-123",
    expire_time=21600,
    email="admin@example.com",
    sso_id="sso-456"
)

The implementation now fully matches the API specification! 🚀

---

Created by Shuni 🐕

[Copilot]

Pull request overview

Adds/updates the Tenant management API to generate a JIT SSO (admin self-service) configuration link with full optional parameter support, aligning the Python SDK surface with the management API spec.

Changes:

• Updated Tenant.generate_sso_configuration_link to accept optional tenant_id, expire_time, email, and sso_id, and to only send provided fields.
• Expanded tenant management tests to cover “all parameters” and “no parameters” request shapes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
descope/management/tenant.py	Expands the SDK method signature and request body construction for SSO configuration link generation.
tests/management/test_tenant.py	Adds unit tests validating request payloads for full and minimal parameter usage.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Coverage report

The coverage rate went from 98.37% to 98.37% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/tenant.py

100% of new lines are covered (100% of the complete file).

[dorsha]

@shuni tenant_id should not be optional, and also fix pr title

[shuni-bot]

🐕 Done! Updated PR: #1534

View workflow run

📋 Actions Taken

View AI response

Perfect! I've completed both requested changes:

✅ Changes Made

1. Made tenant_id Required

Changed the method signature from:

def generate_sso_configuration_link(
    self,
    tenant_id: Optional[str] = None,  # ❌ Was optional
    ...
)

To:

def generate_sso_configuration_link(
    self,
    tenant_id: str,  # ✅ Now required
    ...
)

• Updated the docstring to reflect that tenant_id is required (not optional)
• Updated the test test_generate_sso_configuration_link_minimal_params to pass a tenant_id
• All 4 SSO configuration link tests pass ✅

2. Fixed PR Title

Changed from:

• ❌ [FR][0F83] Add Python SDK Method for JIT SSO Link Generation

To:

• ✅ feat: add generate_sso_configuration_link to Tenant management

The new title follows conventional commits format and accurately describes the feature.

📊 Quality Gate Results ✅

• Format: ✅ Passed (ruff format - 2 files already formatted)
• Lint: ✅ Passed (ruff check - all checks passed)
• Typecheck: ✅ Passed (mypy - no type errors)
• Tests: ✅ Passed (13/13 tenant tests, including all 4 SSO link tests)

💻 Updated Usage

# tenant_id is now required
link = client.mgmt.tenant.generate_sso_configuration_link(
    tenant_id="tenant-123",  # ← Required parameter
    expire_time=21600,        # Optional
    email="admin@example.com",  # Optional
    sso_id="sso-456"          # Optional
)

All changes have been committed and are ready for the PR! 🚀

---

View session on Shuni Portal 🐾