[denson9874]

Requested by Daryl · project thread

Description

On the Pixel 7 Pro (ExpressiveOS Nov 3 build) with Bottom sheet drawer on, the app drawer opened flush with the top of the screen over a sharp home screen: widgets, clock and dock icons showed through the see-through sheet with only a tint and no blur. This PR carries the unmerged fix from #46 onto 5.1.0, adds a self-check that rebuilds the device profile whenever it no longer matches the drawer style, and adds a guard so Home can't show sharp through the sheet.

Supersedes #46 (same first commit, rebased onto current codex/pixel-parity).

Reasoning

Home is meant to stay visible behind the phone sheet, blurred by the depth controller. shouldShowAllAppsOnSheet() reads the setting live, but the sheet's padding, shift range and blur depth (BottomSheetProfile.bottomSheetDepth) are fixed when the DeviceProfile is built. When the two disagree, the sheet layout is used with full screen values: flush with the top, depth 0, no blur, and Home still visible.

1. Known stale paths (from fix(allapps): bottom sheet drawer ghost on the home screen after close #46).
   • Turning the switch on only recreated the activity (reloadHelper.recreate() in 5.1.0), which reuses the cached profiles. This is what happened on the phone on Nov 3 (see Testing).
   • Flags.allAppsSheetForHandheld() reads the preference through a supplier that LawnchairApp installs only at unlock. The process starts locked for TouchInteractionService, and Launcher can be created before that process's unlock callback runs.
   • Fix: the preference rebuilds the grid (restart), and LawnchairApp rebuilds the profiles at unlock when the sheet is on. The scrim stops drawing the closed sheet (the Nov 1 "ghost on home").
2. Self-check (new). DeviceProfile records the sheet setting it was built for, and isAllAppsSheetLayoutStale() compares it with the live setting. LawnchairLauncher.onResume rebuilds the profiles when they are stale, whatever made them so. The dump prints allAppsSheetLayoutStale. A backstop for any other path that leaves the profile stale.
3. Guard. AllAppsState keeps Home visible behind the phone sheet only while a blur will actually be drawn: window blur on, wallpaper depth effect on (with it off DepthController blurs nothing), and a sheet depth above 0. Otherwise Home hides as it does behind the full screen drawer. Tablets are unchanged. Rule: showHomeBehindAllAppsSheet in LawnchairUtils.kt, tests in AllAppsSheetAlphaTest.

Testing

• Phone evidence, Nov 3, 7 Pro with launcher 5.1.0 (72):
  • Trigger: Daryl had just switched the drawer from full screen to bottom sheet. The process that showed the bug (pid 2310, running since boot) had its activity recreated 10 times at 07:20–07:21 ET. Daryl's screenshot came at 07:22. The process exited at 07:26 when a launcher setting restarted it.
  • Since then the drawer blurs: bottomSheetDepth 0.33, allAppsPadding.top 144 px, SurfaceFlinger backgroundBlurRadius 105 with the drawer open. Same before and after a force-stop.
  • Reboot test at 14:50 ET: the launcher process started 2.5 min before unlock, and Launcher was created 0.34 s after unlock. The layout was still healthy and the drawer blurred, so the boot path did not reproduce the bug.
• Source review of the first two commits from three angles (compile/API, behaviour across states and transitions, boot and toggle ordering). No blockers. Minor: with the sheet on, the IDP is rebuilt once more on each cold start.
• CI builds pass on the current head (Play debug, GitHub debug, Nightly release). check-style already fails on the base branch with pre-existing ktlint violations (see comment), and final-status fails only because of it. On this PR it reports 64 Kotlin files both before and after the self-check commit, and spotlessJavaCheck passes.
• Jenkins unit tests, including the new AllAppsSheetAlphaTest cases.
• 7 Pro with a release-signed build: open the drawer after a reboot, after toggling Bottom sheet drawer off and on, and after changing wallpaper colours. Expect Home blurred behind a rounded sheet and allAppsSheetLayoutStale: false in the dump.

Type of change

✅ Bug fix (A non-breaking change that fixes an issue)
❌ New feature (A non-breaking change that adds functionality)
❌ Breaking change (A fix or feature that would cause existing functionality to not work as expected)
❌ Refactor (A code change that neither fixes a bug nor adds a feature)
❌ Performance (A code change that improves performance)
❌ Style (Code style changes)
❌ Docs (Changes to documentation)

🤖 Generated with Claude Code

https://claude.ai/code/session_01Csz3tagmgxj1PfoiZY5Ydo

[denson9874]

check-style (spotlessCheck) is red here, but the failure isn't caused by this PR. It reports ktlint violations in about 60 existing files (FeedBridge.kt, AllAppsSearchInput.kt, SearchItemBackground.kt, AllAppsCategoryTabs.kt, …), and the same check also fails on the base branch, for example on docs-only #47. The fix is a repo-wide ./gradlew spotlessApply in its own PR, already on the 5.0.9 follow-up list, so it's left out of this one. The Kotlin added here uses the formatting ktlint asks for elsewhere in that log (an expression body on the same line as the return type). The three build jobs are the checks that matter for this change.

---

Generated by Claude Code