Repository navigation
Stop re-binding app suggestions on every Home and All Apps transition - #31
Merged
Merged
Conversation
LawnchairLauncher forced a model load and re-bound the hotseat, All Apps and widget prediction containers in onResume and onStateSetEnd. The bind targets rebuild their views unconditionally, so every Home press and All Apps open/close did main-thread view churn with nothing changed. Prediction changes already reach the UI: LawnchairAppPredictor enqueues PredictionUpdateTask, which dispatches through bindItemsUpdated, and bindAll binds the containers on load. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvTcUjdGCFgGq1dgnoXW4W
denson9874
marked this pull request as ready for review
September 29, 2026 20:12
denson9874
added a commit
that referenced
this pull request
Sep 30, 2026
… fixes from public main (#29-#33) Ports the android/ part of public main 938e9c6..73b6592 (PRs #29-#33): - #29 BaseDepthController: skip redundant workspace blur clears and per-frame logging - #30 stop reloading the whole model on every recreate (always-reload-icons default off) - #31 stop re-binding prediction containers on every resume and state change - #32 Pixel-style drawer search: instant results, calculator on by default, opaque focused pill, "Pixel Search (third-party)" label - #33 locale change reloads the model; seeded provider results with session guard; Enter never opens a Play Store search while web suggestions load; calculator only answers real calculations (sqrt added) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Daryl Denson · project thread
Before: every Home press and every All Apps open or close queued a model load and then rebuilt the hotseat suggestions, the All Apps suggestion row and the widget suggestions on the main thread, even when nothing had changed.
After: suggestions are only re-bound when they actually change, so those transitions no longer do that work.
How: removes
refreshPredictionContainersFromModel()and its calls fromLawnchairLauncher.onResumeandonStateSetEnd. Prediction changes still reach the UI.LawnchairAppPredictorenqueuesPredictionUpdateTask, which dispatches throughModelCallbacks.bindItemsUpdated→bindPredictedContainerInfo, andbindAllbinds the containers on first load.Not built locally (no Android SDK in the authoring environment). It is a pure deletion with unused imports removed. On device, check that suggestions still update after launching apps.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GvTcUjdGCFgGq1dgnoXW4W
Generated by Claude Code