Repository navigation
Stop reloading the whole launcher model on every recreate - #30
Merged
Merged
Conversation
Default always_reload_icons to off, and only honour it when an icon pack (or a themed icon pack) is actually active, as its KDoc already claims. Icon pack and themed icon changes still reload through their own preference listeners. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NnvYJsEQUoV9NB8WnVrLez
denson9874
marked this pull request as ready for review
September 29, 2026 20:04
denson9874
added a commit
that referenced
this pull request
Sep 30, 2026
… fixes from public main (#29-#33) Ports the android/ part of public main 938e9c6..73b6592 (PRs #29-#33): - #29 BaseDepthController: skip redundant workspace blur clears and per-frame logging - #30 stop reloading the whole model on every recreate (always-reload-icons default off) - #31 stop re-binding prediction containers on every resume and state change - #32 Pixel-style drawer search: instant results, calculator on by default, opaque focused pill, "Pixel Search (third-party)" label - #33 locale change reloads the model; seeded provider results with session guard; Enter never opens a Play Store search while web suggestions load; calculator only answers real calculations (sqrt added) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Daryl Denson · project thread
Before: every launcher recreate (dark mode switch, wallpaper color change, locale or font change, and the many settings that call
recreate()) threw away the loaded model and rebuilt the workspace, drawer and icons from the DB and PackageManager, because "Always reload icons" defaulted on and never checked for an icon pack.After: a recreate just rebinds the already loaded model. "Always reload icons" defaults off, and when a user turns it on it only fires when an icon pack or themed icon pack is actually active, as its KDoc already says.
How:
config_default_always_reload_iconsis nowfalseinlawnchair/res/values/config.xml, andLawnchairLauncher.reloadIconsIfNeeded()checksiconPackPackage/themedIconPackPackagebefore callingmodel.reloadIfActive(). Icon pack and themed icon preference changes still reload through their ownreloadIconslisteners inPreferenceManager, so switching packs is unaffected. Users who explicitly enabled the setting keep it.Not compiled locally (no Android SDK in the environment); CI is the first build check.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NnvYJsEQUoV9NB8WnVrLez
Generated by Claude Code