Repository navigation
Skip redundant workspace blur clears and per-frame logging - #29
Merged
Merged
Conversation
…ontroller Only clear and invalidate workspace/hotseat RenderEffects when a blur was actually applied, reuse the blur RenderEffect while the radius is unchanged, and drop the Log calls that ran on every depth frame. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TAW7TbURAB9ubVrCLqLMub
denson9874
marked this pull request as ready for review
September 29, 2026 20:06
denson9874
added a commit
that referenced
this pull request
Sep 30, 2026
… fixes from public main (#29-#33) Ports the android/ part of public main 938e9c6..73b6592 (PRs #29-#33): - #29 BaseDepthController: skip redundant workspace blur clears and per-frame logging - #30 stop reloading the whole model on every recreate (always-reload-icons default off) - #31 stop re-binding prediction containers on every resume and state change - #32 Pixel-style drawer search: instant results, calculator on by default, opaque focused pill, "Pixel Search (third-party)" label - #33 locale change reloads the model; seeded provider results with session guard; Enter never opens a Play Store search while web suggestions load; calculator only answers real calculations (sqrt added) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
denson9874
added a commit
that referenced
this pull request
Sep 30, 2026
…ge-following labels, bump to v4.0.0 (49) Major release built on the #29-#33 port: instant drawer search that keeps rows in place, opaque focused pill, calculator on by default and only for real calculations, Enter searches the web, fewer blur clears, no full model reload on recreate, no prediction re-binds on resume, and labels that follow a system language change. Default changes: "Always reload icons" off unless set, calculator results on. Changelog 49, 4.0.0 announcement and parity ledger updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Daryl Denson · project thread
Before: on every depth frame (app open/close, All Apps transitions),
BaseDepthControllercleared the RenderEffect on Workspace and Hotseat and force-invalidated them, even when no blur was set. It also allocated a new blurRenderEffecteach frame during All Apps transitions and built log strings every frame.After: Workspace and Hotseat are only cleared and invalidated when a blur was actually applied, the blur effect is reused while the radius stays the same, and the per-frame
Log.v/Log.dcalls are gone.How: a
mWorkspaceEffectAppliedflag gates the per-frame clear via a new privateclearWorkspaceRenderEffectsIfApplied(). The publicclearWorkspaceRenderEffects()still clears unconditionally (and resets the flag), so the existing stuck-blur workarounds inDepthControllerandFolderbehave as before. Re-setting the cached effect every blur frame is a no-op inView.setRenderEffectwhen unchanged, and restores the blur if something external cleared it.Not compiled or run here (no Android SDK in the environment); needs an on-device check that All Apps and swipe-home blur/un-blur cleanly.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TAW7TbURAB9ubVrCLqLMub
Generated by Claude Code