Skip to content

SLS - Clarify Constraints - #46367

Open
TheL0L wants to merge 6 commits into
masterfrom
syakima/xsup-79083/sls-clarify-constraints
Open

SLS - Clarify Constraints#46367
TheL0L wants to merge 6 commits into
masterfrom
syakima/xsup-79083/sls-clarify-constraints

Conversation

@TheL0L

@TheL0L TheL0L commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Related Issues

related: XSUP-79083

Related MR

Description

Exclude "all" value of Severity and Subtype from blocking query construction.
Update the documentation regarding this behavior.

@content-bot

content-bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions

github-actions Bot commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CortexDataLake/Integrations/CortexDataLake
   CortexDataLake.py75425466%138–139, 249–253, 256–257, 260, 264, 272, 274, 280, 283, 307–311, 314–316, 322–323, 386–387, 442–447, 449–451, 460–464, 466–467, 491, 493–495, 497, 530, 532–534, 537–540, 542–545, 552, 559–563, 565–570, 572, 584, 588, 591, 604–606, 738, 792, 852, 907, 1098–1103, 1138–1139, 1203, 1206, 1226, 1229, 1231–1233, 1272–1273, 1275, 1286, 1288, 1290, 1292–1294, 1296–1297, 1344–1348, 1434–1437, 1442–1446, 1530, 1547–1550, 1552–1553, 1555, 1557, 1559–1561, 1586, 1604–1607, 1609–1610, 1612, 1614, 1616–1618, 1633, 1650–1651, 1653–1655, 1657–1658, 1660, 1662, 1664–1666, 1675–1678, 1687–1690, 1711–1714, 1735–1738, 1754–1757, 1837–1839, 1841–1842, 1844–1846, 1849–1852, 1854–1856, 1858–1862, 1900–1902, 1928–1973, 1984–1988
TOTAL75425466% 

Tests Skipped Failures Errors Time
108 0 💤 0 ❌ 0 🔥 2.866s ⏱️

@TheL0L TheL0L self-assigned this Oct 22, 2026
@TheL0L TheL0L added python Pull requests that update Python code ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Oct 22, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Oct 22, 2026
@marketplace-ai-reviewer

marketplace-ai-reviewer commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

marketplace-ai-reviewer commented Oct 22, 2026

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Oct 22, 2026
View reviewed changes

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for your contribution!

The changes look solid overall, with just a couple of minor documentation and formatting tweaks to address. Please ensure the full parameter names are used in the integration README to avoid any confusion, and update the release notes formatting to follow the standard entity styling guidelines (using italics for parameters and values).

Once those adjustments are made, this should be good to go!

@richardbluestone, @TheL0L please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/CortexDataLake/Integrations/CortexDataLake/README.md Outdated
Comment thread Packs/CortexDataLake/ReleaseNotes/1_6_4.md Outdated
@content-bot

This comment has been minimized.

Sign in to view
@TheL0L
TheL0L marked this pull request as ready for review October 22, 2026 19:17
@content-bot

content-bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Validate summary
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

content-bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: cd4ad3ea2b6c0929

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments
@richardbluestone richardbluestone Awaiting requested review from richardbluestone

At least 1 approving review is required to merge this pull request.

Assignees

@TheL0L TheL0L

Labels

python Pull requests that update Python code ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheL0L @content-bot @marketplace-ai-reviewer