Skip to content

SLS - Improve Test Module Reliability - #46363

Open
TheL0L wants to merge 4 commits into
masterfrom
syakima/xsup-78274/sls-query-time-limit
Open

TheL0L wants to merge 4 commits into
masterfrom
syakima/xsup-78274/sls-query-time-limit

Conversation

@TheL0L

@TheL0L TheL0L commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Related Issues

related: XSUP-78274

Description

Bound the connectivity test query to the last hour.

@TheL0L TheL0L self-assigned this Oct 22, 2026
@TheL0L TheL0L added docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Oct 22, 2026
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Oct 22, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for your contribution!

Overall the changes look good, but we noticed that the new build_connectivity_test_query function is missing unit tests. Please add test coverage in CortexDataLake_test.py to ensure the generated query includes the expected table, limit, and time bounds.

Once that's added, we should be good to proceed!

@TheL0L please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/CortexDataLake/Integrations/CortexDataLake/CortexDataLake.py
@content-bot

This comment has been minimized.

@TheL0L
TheL0L marked this pull request as ready for review October 22, 2026 19:18
@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 07041f1e5cad1592

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants