Skip to content

ZENDESK : create or update ticket with attachements - #46329

Open
o101010 wants to merge 3 commits into
demisto:contrib/o101010_feature/zendesk/create_ticket_with_attachementsfrom
o101010:feature/zendesk/create_ticket_with_attachements
Open

o101010 wants to merge 3 commits into
demisto:contrib/o101010_feature/zendesk/create_ticket_with_attachementsfrom
o101010:feature/zendesk/create_ticket_with_attachements

Conversation

@o101010

@o101010 o101010 commented Oct 19, 2026 •

Copy link
Copy Markdown

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

@CLAassistant

CLAassistant commented Oct 19, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 19, 2026
@content-bot
content-bot changed the base branch from master to contrib/o101010_feature/zendesk/create_ticket_with_attachements October 19, 2026 17:16
@content-bot
content-bot requested a review from kamalq97 October 19, 2026 17:16
@content-bot

Copy link
Copy Markdown
Contributor

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot

Copy link
Copy Markdown
Contributor

Hi @o101010, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

Hi @kamalq97, you can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@ilappe
ilappe requested review from ilappe and lironcohen272 and removed request for ilappe and kamalq97 October 20, 2026 10:04
@ilappe ilappe assigned lironcohen272 and unassigned kamalq97 Oct 20, 2026
@lironcohen272 lironcohen272 added ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Oct 21, 2026
@content-bot

Copy link
Copy Markdown
Contributor

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot

Copy link
Copy Markdown
Contributor

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/13996991

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Oct 21, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Oct 21, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this contribution!

Overall, the feature looks great, but there are a few key areas that need attention:

  • Error handling & edge cases: Avoid using assert for user input validation, safely handle demisto.getFilePath() returns, and ensure comment is properly initialized in ticket payloads to prevent potential KeyErrors when uploading attachments without text comments.
  • Packaging & Docs: Because this introduces a new capability, please bump the pack version to a minor release (2.2.0) rather than a patch, and align argument descriptions in the YAML and README for list inputs.
  • Testing: Please consider adding unit tests covering attachment updates and invalid input edge cases.

Once those are sorted out, this should be good to go!

@lironcohen272 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.py
Comment thread Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.py Outdated
Comment thread Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.py Outdated
Comment thread Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.py Outdated
Comment thread Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.py
Comment thread Packs/Zendesk/Integrations/Zendeskv2/README.md Outdated
Comment thread Packs/Zendesk/Integrations/Zendeskv2/README.md Outdated
Comment thread Packs/Zendesk/Integrations/Zendeskv2/README.md Outdated
Comment thread Packs/Zendesk/Integrations/Zendeskv2/README.md Outdated
Comment thread Packs/Zendesk/ReleaseNotes/2_2_0.md
@lironcohen272

Copy link
Copy Markdown
Contributor

Hi @o101010 , Thank you for your contribution.

To proceed with the review process, please:

  1. Sync your branch with the latest changes from master.
  2. Review the Marketplace AI Review comments. For better tracking, please resolve all comments that you address and commit, and leave a comment on any comments that are not relevant.
  3. In Zendeskv2.yml file, supportedModules: [agentix, xsiam] was removed from four configuration parameters. Could you clarify the reason for this change and restore it if it was unintentional?
  4. Update docker image:
    Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.yml: [DO106] - docker image demisto/python3:3.12.13.10116658's tag 3.12.13.10116658 is outdated. The latest tag is 3.12.14.13919218 Validate summary

Please let me know if you have any questions. Thank you!

@lironcohen272 lironcohen272 added the pending-contributor The PR is pending the response of its creator label Oct 22, 2026
@o101010
o101010 requested a review from JasBeilin as a code owner October 22, 2026 14:34
@o101010

o101010 commented Oct 22, 2026

Copy link
Copy Markdown
Author

Hi @lironcohen272 ,

Thank you for reviewes.

  1. Normally, sync is done
  2. All Marketplace AI Review comments has been address
  3. In Zendeskv2.yml file, supportedModules: [agentix, xsiam] has been automatically removed by demisto-sdk format. I restore them manually.
  4. Docker image has been updated, with a comment in release note for that.

@o101010
o101010 force-pushed the feature/zendesk/create_ticket_with_attachements branch from f85441a to 96aa48d Compare October 22, 2026 15:41
@o101010 o101010 closed this Oct 22, 2026
@o101010
o101010 deleted the feature/zendesk/create_ticket_with_attachements branch October 22, 2026 15:44
@o101010
o101010 restored the feature/zendesk/create_ticket_with_attachements branch October 22, 2026 15:46
@o101010 o101010 reopened this Oct 22, 2026
@o101010
o101010 force-pushed the feature/zendesk/create_ticket_with_attachements branch from 96aa48d to 126837e Compare October 22, 2026 15:53
@o101010

o101010 commented Oct 22, 2026

Copy link
Copy Markdown
Author

Sorry for the noise!
I accidentally messed up the PR's history while trying to clean it up, which added unrelated contributors and reviewers. I've fixed the branch history, and the PR now contains only my three commits. Apologies for the confusion, and thanks for your patience!

@lironcohen272 lironcohen272 added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed pending-contributor The PR is pending the response of its creator labels Oct 22, 2026
@content-bot

Copy link
Copy Markdown
Contributor

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot

Copy link
Copy Markdown
Contributor

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/14033057

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Oct 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants