Repository navigation
ZENDESK : create or update ticket with attachements - #46329
Conversation
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed. |
🤖 AI-Powered Code Review AvailableHi @kamalq97, you can leverage AI-powered code review to assist with this PR! Available Commands:
|
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/13996991 |
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Thanks for working on this contribution!
Overall, the feature looks great, but there are a few key areas that need attention:
- Error handling & edge cases: Avoid using
assertfor user input validation, safely handledemisto.getFilePath()returns, and ensurecommentis properly initialized in ticket payloads to prevent potentialKeyErrors when uploading attachments without text comments. - Packaging & Docs: Because this introduces a new capability, please bump the pack version to a minor release (
2.2.0) rather than a patch, and align argument descriptions in the YAML and README for list inputs. - Testing: Please consider adding unit tests covering attachment updates and invalid input edge cases.
Once those are sorted out, this should be good to go!
@lironcohen272 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
|
Hi @o101010 , Thank you for your contribution. To proceed with the review process, please:
Please let me know if you have any questions. Thank you! |
|
Hi @lironcohen272 , Thank you for reviewes.
|
f85441a to
96aa48d
Compare
…the commands ***zendesk-ticket-create*** and ***zendesk-ticket-update***.
96aa48d to
126837e
Compare
|
Sorry for the noise! |
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/14033057 |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues