[srusia-delphix]

Problem

The masking engine is moving from Hop 1.2.0 to a 2.x line. Hop 2.15 was the original target, but it carries a performance regression in org.apache.hop.core.Condition that makes delimited-file masking roughly 3x slower (see DLPX-99491 and #16): evaluate() rebuilds the right-hand ValueMeta on every row, and under the masking SecurityManager each rebuild costs a policy evaluation.

Apache fixed that regression in 2.17.0, so targeting 2.17 removes the need to carry a Delphix patch for it at all.

Evaluation

2.17.0 is the only version that both fixes the regression and runs on Java 17. Upstream's fix, introduced in 2.17.0 and absent in 2.15/2.16, caches the constant right value in Condition itself:

// Right value is a constant - cache it for performance
if (!rightValueCached) {
  cachedFieldMeta2 = rightValue.createValueMeta();
  cachedField2     = rightValue.createValueData();
  rightValueCached = true;
}

invalidated via clearFieldPositions(), which FilterRows.init() calls once per transform copy per run.

Solution

New delphix/hop-2.17 branch cut from upstream 2.17.0, with the existing Delphix patch set re-applied as a single commit.

This PR replicates #12 (the 2.15 branch creation) onto 2.17 with no additional changes.

Testing Done

CI on this PR: build pass, style checks pass, Jira checks pass.

Compatibility and risk verification performed against upstream artifacts (all reproducible from published jars and the Apache repo):

Notes to Reviewers

One file fewer than the 2.15 patch set. #12 also patched ui/.../PreviewRowsDialogTest.java, which is not carried here as it is removed in upstream 2.17.

[Copilot]

Copilot review overview

🟡 Changes recommended

Database metadata handling, polling configuration, and batch exception reporting contain unresolved functional regressions.

Review effort: Balanced
Findings: 5 · 2

Open (7)

• Preserve database channel log level in emptyAndCommit() · New
• Check original JDBC type for DECIMAL and NUMERIC handling · New
• Apply Oracle RAW binary semantics to regular query results · New
• Use original JDBC type to detect BLOB columns · New
• Restore configured polling timeout for multi-input reads · New
• Correct spelling of suppressed · New
• Use plural types to match these · New

What changed in this PR

Ports the Delphix masking customizations onto Apache Hop 2.17, including database compatibility, runtime configuration, and internal artifact publishing.

Changes:

• Configures Delphix Artifactory publishing and dependency resolution.
• Reapplies database metadata, fetch-size, and exception-reporting customizations.
• Updates launch classpaths and related tests.

File	Description
settings.xml	Adds Delphix Artifactory settings.
pom.xml	Configures internal artifact deployment.
plugins/​databases/​oracle/​.../​OracleValueMetaBaseTest.java	Updates Oracle binary metadata expectations.
engine/​.../​BaseTransform.java	Changes input polling timeout behavior.
core/​.../​ValueMetaBaseTest.java	Updates null-string conversion expectation.
core/​.../​ValueMetaBase.java	Adds database type and JDBC handling customizations.
core/​.../​HopDatabaseBatchException.java	Reports chained SQL exceptions.
core/​.../​Database.java	Adds configurable fetch sizing and logging propagation.
assemblies/​.../​hop-run.sh	Extends runtime classpath.
assemblies/​.../​hop-gui.sh	Extends GUI classpath.
.gitignore	Ignores local snapshots.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sandeep-delphix]

LGTM, just small NIt's