fix(dataset): add missing router field to project_default network_spec.yml - #605
Merged
abhishek-sa1 merged 1 commit intoAug 13, 2026
Conversation
…c.yml The mandatory 'router' field was added to admin_network in omnia commit d730b7dc8 (network_spec schema + deploy_openchami.yml), but the project_default test dataset was never updated. This causes prepare_oim molecule tests to fail at L1 schema validation with exit code 2. Add router: "172.16.107.254" (matching primary_oim_admin_ip) and update the comments to document the field, consistent with omnia/input/network_spec.yml and the network_spec.j2 template. Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
abhishek-sa1
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routerfield todatasets/project_default/network_spec.ymladmin_network sectionrouterdocumentation to the file comments, consistent withomnia/input/network_spec.ymlRoot Cause
The mandatory
routerfield was added toadmin_networkin omnia commitd730b7dc8which updated:network_spec.json) —routeradded torequiredarraydeploy_openchami.yml—coredhcp_router: "{{ network_data.admin_network.router }}"omnia/input/network_spec.ymlHowever, the
project_defaulttest dataset in omnia-containers was not updated, causingprepare_oimmolecule tests to fail at L1 schema validation with Ansible exit code 2.Changes
datasets/project_default/network_spec.ymlrouter: "172.16.107.254"(matchingprimary_oim_admin_ip) and documentation commentsTest Plan
prepare_oimmolecule converge passes L1 schema validationprepare_oimmolecule verify passes all sanity testsSigned-off-by: Sujit Jadhav sujit.jadhav@dell.com