Repository navigation
deps(web): move the wizard to SvelteKit 3 - #313
Merged
Merged
Conversation
Dependabot's #300 (kit 3.1.0) failed npm ci: adapter-static 3 accepts only kit 2. This takes kit to 3.1.1 and adapter-static to 4.0.1, and makes the changes SvelteKit 3's migration guide asks of this project: - tsconfig.json extends $app/tsconfig and lists its files; - $lib, no longer generated, becomes #lib, a subpath import declared in package.json, with each TypeScript module's .js extension; - the cookie override (^0.7.2, for GHSA-pxg6-pf52-xh8x under kit 2) is removed: kit 3 depends on cookie ^2.0.1; - version.pollInterval is 0: kit 3 polls for a new deployment hourly by default, and the wizard ships inside the binary that serves it. It clears GHSA-27mw-82g8-phjj and GHSA-pfhg-q3qv-9q6r (fixed in kit 3.0.0). Neither reached the wizard, which sets no headers and has no form actions, but both are counted against the repository. web/osv-scanner.toml records GHSA-gcqx-w48m-w2h4 (deepmerge) as not applying, as tools/socair-sigstore/osv-scanner.toml does for its module: vite-plugin-svelte merges the project's own options with it at build time, nothing from a user or a model reaches it, it is not in the bundle, and there is no patched version. npm run check (0 errors), npm test (76 passed), and npm run build pass. The built wizard, served by socair serve, ran a scan and showed the engine's report. Signed-off-by: Christopher Maher <chris@mahercode.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #300. That PR bumped
@sveltejs/kitto 3.1.0 alone, andnpm cifailed because@sveltejs/adapter-static3.0.10 accepts only kit ^2.This PR moves kit to 3.1.1 and adapter-static to 4.0.1, and makes the changes the SvelteKit 3 migration guide asks of the wizard:
tsconfig.jsonextends$app/tsconfigand lists its owninclude, which$app/tsconfigleaves out.$libbecomes#lib: SvelteKit no longer generates$lib.#libis a subpath import declared inpackage.jsonimports. The 30 imports now carry the.jsextension the guide asks for on TypeScript modules. Thealiasoption would have kept$lib, but SvelteKit 3 deprecates it.^0.7.2was there for GHSA-pxg6-pf52-xh8x under kit 2. Kit 3 depends on cookie^2.0.1, and the override would have forced it back to 0.7.version.pollInterval: 0: kit 3 polls for a new deployment hourly by default. The wizard ships inside the binary that serves it and never readsupdated, so it keeps kit 2's behavior and doesn't poll.Alerts
This closes Dependabot B1 GGUF reader #4 and B3 Provenance and lineage #5: GHSA-27mw-82g8-phjj and GHSA-pfhg-q3qv-9q6r, both fixed in kit 3.0.0. Neither reached the wizard, which sets no headers and has no form actions or
use:enhance. OpenSSF Scorecard counts them anyway.web/osv-scanner.tomlrecords GHSA-gcqx-w48m-w2h4 (deepmerge) as not applying, the waytools/socair-sigstore/osv-scanner.tomldoes for GO-2026-5932:The Dependabot alert was already dismissed with the same reason.
Checks
npm run check: 0 errors and 0 warnings.npm test: 76 passed.npm run build: writesbuild/with no deprecation warnings.socair serve --web, loaded/scan, ran a scan of a small safetensors file, and showed the engine's report and promotion state. The one console error was the airlock log's expected 400, since the server ran without--store.Assisted-by: Claude Code (made the migration and ran the checks; the maintainer's review is pending)