Repository navigation
fix: warn about unmatched model file patterns - #2472
Open
aditya-rai-5 wants to merge 1 commit into
Open
aditya-rai-5 wants to merge 1 commit into
aditya-rai-5 wants to merge 1 commit into
Conversation
Signed-off-by: aditya-rai-5 <aditya5748rai@gmail.com>
Defilan
approved these changes
Nov 7, 2026
Defilan
left a comment
Member
There was a problem hiding this comment.
Thanks. This gives the signal #2458 asked for without changing what becomes Ready, and it needs no extra repository calls. The event fires only when the condition changes, so repeated reconciles stay quiet.
One small gap, not blocking: TestReconcile_UnmatchedFilePatternsOCI checks that the condition is set, but not that it clears once spec.files is corrected, which the other test covers for the runtime and prefetch paths. Add it here if you like, or leave it for a follow-up.
I've started CI. This can merge once it's green.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Report secondary
spec.filesglobs that match no repository files through anUnmatchedFilePatterns=Truecondition and a Warning event naming the patterns.Models can still become
Ready; unmatched secondary globs remain nonfatal.Why
A typo such as
*.safetensorcould silently omit model weights while the Model reportedReady, leaving users without a clear cause for runtime loading failures.Fixes #2458
How
Regression tests reproduced the missing condition before the fix and now cover persisted warnings, event deduplication, cleanup after spec correction, and OCI publishing.
Validation: focused regression and adjacent tests passed.
make test-affectedandmake gatealso passed locally.Assisted-by: Codex (generated the regression tests, and documentation).
Checklist
make testpasses locallymake lintpasses locallygit commit -s) per DCO