Repository navigation
fix: avoid stale namespace reads in quota admission - #2471
Open
aditya-rai-5 wants to merge 1 commit into
Open
aditya-rai-5 wants to merge 1 commit into
aditya-rai-5 wants to merge 1 commit into
Conversation
Signed-off-by: aditya-rai-5 <aditya5748rai@gmail.com>
Defilan
approved these changes
Nov 7, 2026
Defilan
left a comment
Member
There was a problem hiding this comment.
Thanks, this is the right fix. Reading the Namespace through mgr.GetAPIReader() removes the stale NotFound, and it also means a selector quota sees fresh labels. The operator already has get on namespaces, so no RBAC change is needed. The tests cover a brand new Namespace, stale labels and a Namespace that really is missing.
I've started CI. This can merge once it's green.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix quota admission rejecting an InferenceService immediately after its Namespace is created.
Why
The webhook reads Namespaces through the manager’s cache. A newly created Namespace may not have reached the cache, causing admission to fail with
Namespace not found.Fixes #2459
How
mgr.GetAPIReader().Assisted-by: Codex (implemented the regression tests).
Checklist
make testpasses locallymake lintpasses locallygit commit -s) per DCO