Skip to content

Added pytests for plotcorrelation tool#1370

Closed
SaimMomin12 wants to merge 4 commits into
deeptools:4.0.0from
SaimMomin12:pytest_plotcorrelation
Closed

Added pytests for plotcorrelation tool#1370
SaimMomin12 wants to merge 4 commits into
deeptools:4.0.0from
SaimMomin12:pytest_plotcorrelation

Conversation

@SaimMomin12

@SaimMomin12 SaimMomin12 commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :

  • Does the PR contain new feature?
  • Does the PR contain bugfix?
  • Does the PR contain documentation changes?
  • Does the PR contain changes to the galaxy wrapper?
  • Does something else

This PR adds pytests for plotcorrelation tool.

pavanvidem
pavanvidem reviewed Jan 23, 2025
View reviewed changes
Comment thread pydeeptools/deeptools/test/test_plotcorrelation.py Outdated
Comment thread pydeeptools/deeptools/test/test_plotcorrelation.py Outdated
@adRn-s adRn-s mentioned this pull request Jul 8, 2026
Merged
adRn-s added a commit that referenced this pull request Jul 8, 2026
@adRn-s @SaimMomin12
Add pytests for plotCorrelation (salvage of #1370) (#1432)
ee0a7c4 
* Added pytest for plotcorrelation

* Add missing file

* relaxed size tolerance

* Replace file size test with compare image

---------

Co-authored-by: Saim Momin <mominsaim12@gmail.com>
@adRn-s

adRn-s commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #1432, which rebases this onto current 4.0.0 and is verified passing (image compare within tolerance, correlation-matrix values match). Closing in favor of that. Thanks @SaimMomin12! 🙏

@adRn-s adRn-s closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavanvidem pavanvidem pavanvidem left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaimMomin12 @adRn-s @pavanvidem