Added some tests for the rust functions#1369
Closed
gerikson wants to merge 7 commits into
Closed
Conversation
Collaborator
|
@gerikson Can you change the target of this PR to 4.0.0 instead of master branch? |
Collaborator
|
@gerikson FYI, @SaimMomin12 and me are creating tests for |
adRn-s
added a commit
that referenced
this pull request
Jul 8, 2026
Salvaged from #1369: keeps only the computeMatrix test, which passes against the current Rust bindings. The alignmentSieve, bamCompare and bamCoverage tests from that PR were dropped because their Rust function signatures have since changed (and alignmentSieve2 is not yet wired up on 4.0.0). Co-authored-by: gerikson <galina.erikson@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
Partially salvaged in #1433, which keeps the
These can be revisited once those tools' Rust APIs settle. Closing in favor of #1433 — thanks @gerikson! 🙏 |
adRn-s
added a commit
that referenced
this pull request
Jul 9, 2026
…t/strand filtering (#1434) Fills coverage gaps identified while triaging the stalled #1369 tests: - bamCoverage: --normalizeUsing RPKM (RPKM was untested; suite only had CPM/RPGC) and --scaleFactor. - alignmentSieve: --minFragmentLength/--maxFragmentLength and --filterRNAstrand (neither was tested anywhere). Expected values derived by running the current tools; all pass under `pixi run pytest`. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :