Conversation
lgoltz
marked this pull request as draft
August 6, 2026 07:26
dstenger
approved these changes
Aug 10, 2026
Member
|
TMC discussed this topic in length but didn't reach a final conclusion yet. One thing that came up was the question of how to facilitate both novices and expert users. We are leaning to not using ServiceLoader for this functionality but reaching for a tunable param instead. Such a param could provide a implementation class to be used by the WMS. By providing multiple sensible 'stock' implementations (e.g. DenyAll, AllowAll) for the user to choose from and provide an extension point for system integrator to plug-in their own functionality we serve both kinds of users. The TMC planned to revisit this topic in the next TMC meeting. Others are kindly invited to comment on this issue to share their point of view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the parsing of the sld parameter. Currently only parsing from a http url is supported. This PR adds a SldProvider which can be implemented to allow specific access to SLD files, e.g. from S3 .