fix umask

tests-ng/chmod-install.sh

@@ -28,6 +28,9 @@ echo -e "$(tput setaf 6)==> RUNNING $(basename "${BASH_SOURCE[0]}") <==$(tput sg
 # this is the test
 ################################################################
 
+# pin umask so created files/dirs match the expected modes
+umask 022
+
 # $1 path
 # $2 rights
 has_rights()

tests-ng/chmod-preserve-install.sh

@@ -26,6 +26,9 @@ echo -e "$(tput setaf 6)==> RUNNING $(basename "${BASH_SOURCE[0]}") <==$(tput sg
 # this is the test
 ################################################################
 
+# pin umask so created files/dirs match the expected modes
+umask 022
+
 # $1 path
 # $2 rights
 has_rights()

tests-ng/install.sh

@@ -27,6 +27,9 @@ echo -e "$(tput setaf 6)==> RUNNING $(basename "${BASH_SOURCE[0]}") <==$(tput sg
 # this is the test
 ################################################################
 
+# pin umask so created files/dirs match the expected modes
+umask 022
+
 get_file_mode()
 {
   u=$(umask)

tests/test_compare.py

@@ -39,7 +39,8 @@ def compare(self, opt, tmp, nbdotfiles):
         for dotfile in dotfiles:
             path = os.path.expanduser(dotfile.dst)
             ret, _, insttmp = inst.install_to_temp(templ, tmp, dotfile.src,
-                                                   dotfile.dst)
+                                                   dotfile.dst,
+                                                   chmod=dotfile.chmod)
             if not ret:
                 results[path] = False
                 continue

tests/test_install.py

@@ -554,6 +554,12 @@ def test_creates_dst(self):
 
     def test_prompts_to_replace_dst(self):
         """test prompts to replace dst"""
+        # pin umask so the created destination directory matches the
+        # source directory's mode (0o755) and the "replace" prompt is
+        # the only prompt issued
+        saved_umask = os.umask(0o022)
+        self.addCleanup(os.umask, saved_umask)
+
         # create source dir
         src_dir = get_tempdir()
         self.assertTrue(os.path.exists(src_dir))