Skip to content

Worker loads the blob extension that finds new outbox blobs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fw2568 wants to merge 1 commit into from
Closed

Worker loads the blob extension that finds new outbox blobs #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/workers/src/Dbosoft.Bote.BoteWorker/Dbosoft.Bote.BoteWorker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,29 @@
<ProjectReference Include="..\..\..\Dbosoft.Bote.Primitives\Dbosoft.Bote.Primitives.csproj" />
<ProjectReference Include="..\..\..\Dbosoft.Bote.Rebus.Integration\Dbosoft.Bote.Rebus.Integration.csproj" />
</ItemGroup>
<!--
The blob extension the Functions host loads is the one the worker package names: 6.8.2 names
5.3.8, whose container scan finds only blobs written before the host's first poll, so attachments
from the cloud reach a client only after a restart (Azure/azure-sdk-for-net#61660, fixed in
5.3.10). No worker package names 5.3.10 yet and the SDK takes no override, so the generated
extension project is pointed at it here. The build fails once the worker package names another
version: then this target is to go.
-->
<PropertyGroup>
<_BlobsExtensionNamed>5.3.8</_BlobsExtensionNamed>
<_BlobsExtensionFixed>5.3.10</_BlobsExtensionFixed>
</PropertyGroup>
<Target Name="_PinFixedBlobsExtension" AfterTargets="_FunctionsGenerateCommon" Condition="'$(_FunctionsBuildEnabled)' == 'true'">
<PropertyGroup>
<_NamedBlobsReference>&lt;PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage.Blobs" Version="$(_BlobsExtensionNamed)" /&gt;</_NamedBlobsReference>
<_FixedBlobsReference>&lt;PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage.Blobs" Version="$(_BlobsExtensionFixed)" /&gt;</_FixedBlobsReference>
<_ExtensionsProject>$([System.IO.File]::ReadAllText($(ExtensionsCsProj)))</_ExtensionsProject>
</PropertyGroup>
<Error Condition="!$(_ExtensionsProject.Contains($(_NamedBlobsReference))) AND !$(_ExtensionsProject.Contains($(_FixedBlobsReference)))"
Text="The worker package no longer names blob extension $(_BlobsExtensionNamed); remove _PinFixedBlobsExtension." />
<WriteLinesToFile Condition="$(_ExtensionsProject.Contains($(_NamedBlobsReference)))" File="$(ExtensionsCsProj)"
Lines="$([MSBuild]::Escape($(_ExtensionsProject.Replace($(_NamedBlobsReference), $(_FixedBlobsReference)))))" Overwrite="true" WriteOnlyWhenDifferent="true" />
</Target>
<ItemGroup>
<InternalsVisibleTo Include="Dbosoft.Bote.Rebus.IntegrationTests" />
<InternalsVisibleTo Include="Dbosoft.Bote.BoteWorker.Tests" />
Expand Down
20 changes: 20 additions & 0 deletions test/Dbosoft.Bote.BoteWorker.Tests/HostExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
using AwesomeAssertions;

namespace Dbosoft.Bote.BoteWorker.Tests;

public class HostExtensionsTests
{
/// <summary>
/// Before 5.3.10 the outbox trigger finds only blobs written before the host's first poll: an
/// attachment from the cloud then waits for a restart of the worker (Azure/azure-sdk-for-net#61660).
/// </summary>
[Fact]
public void The_host_loads_a_blob_extension_that_finds_new_blobs()
{
var file = Path.Combine(AppContext.BaseDirectory, ".azurefunctions", "Microsoft.Azure.WebJobs.Extensions.Storage.Blobs.dll");
File.Exists(file).Should().BeTrue("the worker's build puts the host's extensions there");

var version = System.Diagnostics.FileVersionInfo.GetVersionInfo(file).ProductVersion!.Split('+')[0];
Version.Parse(version).Should().BeGreaterThanOrEqualTo(new Version(5, 3, 10));
}
}
Loading