Repository navigation
Client signs with its configured key id or its key's thumbprint - #5
Merged
Merged
Conversation
The client always signed as tenant-client, whatever key id it was given, so the identity provider could hold one key per client and a new key could not be registered beside the old. The key generator names a key by the same thumbprint.
fw2568
force-pushed
the
fix/client-key-id
branch
from
October 25, 2026 01:14
f6233ab to
dde40ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client always signed as tenant-client, whatever KeyId it was configured with, so an identity provider could hold one key per client and a new key could not be registered beside the old one. It now signs with Authentication:KeyId when set, else with the key's RFC 7638 thumbprint; the key generator names keys the same way.