Skip to content

Fix flaky ConductorTest latch timeouts caused by ChaosTest starving the common ForkJoinPool #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxdml merged 2 commits into from
Jul 27, 2026
Merged

Fix flaky ConductorTest latch timeouts caused by ChaosTest starving the common ForkJoinPool #458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b12511
Run ChaosTest's blocked startWorkflow off the common ForkJoinPool
maxdml Jul 16, 2026
4ddcd41
Merge branch 'main' into fix-chaostest-commonpool-starvation
maxdml Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion transact/src/test/java/dev/dbos/transact/database/ChaosTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,12 @@ public void toxiProxyTest() throws Exception {

// Scenario 1: proxy disabled — simulates a sustained network partition
proxy.disable();
// Dedicated thread: this blocks in dbRetry while the proxy is down, and must

@devhawk devhawk Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run this test @isolated and/or @execution(ExecutionMode.SAME_THREAD)?

@maxdml maxdml Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thread would have supplyAsync run on the same coomon pool and isolated slows down test without really solving the problem

// not pin a common ForkJoinPool worker (starves unrelated tests' callbacks).
var wf1 =
CompletableFuture.supplyAsync(
() -> dbos.startWorkflow(() -> svc.dbLossBetweenSteps()));
() -> dbos.startWorkflow(() -> svc.dbLossBetweenSteps()),
r -> new Thread(r, "chaos-wf1").start());
Thread.sleep(3000);
proxy.enable();
assertEquals("Hehehe", wf1.get(10, TimeUnit.SECONDS).getResult());
Expand Down