Class reloading#56
Open
flvrone wants to merge 2 commits into
Open
Conversation
Danger ReportWarnings
MarkdownsHere's an example of a CHANGELOG.md entry: * [#56](https://github.com/dblock/ruby-enum/pull/56): Class reloading - [@flvrone](https://github.com/flvrone). |
dblock
requested changes
Jun 17, 2026
dblock
left a comment
dblock
left a comment
Owner
There was a problem hiding this comment.
Good stuff! Update CHANGELOG and take care of my nits below?
| end | ||
| end | ||
|
|
||
| # rubocop:disable Rspec/DescribedClass |
Owner
There was a problem hiding this comment.
Let's just rubocop -a; rubocop --auto-gen-config these or disable the rule?
|
|
||
| # rubocop:disable Rspec/DescribedClass | ||
| describe 'Reloading enum definition' do | ||
| it 'plays nice with lazy loading in Ruby on Rails' do |
Owner
There was a problem hiding this comment.
Nit: maybe just say "can be lazy reloaded" ... also bald is not a hairstyle :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes when accessing enum classes from rails console -
DuplicateKeyErroris raised, because the class was already loaded (evaluated), but then for whatever reason it tried to load again (evaluate the whole body again), and the previous definitions are still in those instance variables, so it breaks.Now upon including the module - the instance variable is cleared, and it does not break inheritance. (This issue #49 was already solved and tested, and my PR does not break it).