Repository navigation
taki/implement-onboarding - #2
Merged
Merged
Conversation
…e patterns - Rename `SplashPresenter`, `AuthPresenter`, and `ProfileSetupPresenter` to `SplashViewModel`, `AuthViewModel`, and `ProfileSetupViewModel` - Implement `EventHandler` interfaces and `UiAction` channels for navigation and side effects - Decouple presentation components into dedicated files and packages - Integrate `DispatcherProvider` for explicit coroutine context management - Remove `libs:presentation` module and consolidate dependencies in `:feature:onboarding:presentation` - Update Koin modules and iOS dependency injection helpers to reflect renaming
…oseApp dependencies
- Integrate `androidx.splashscreen` and configure `Theme.Yaseyo.Starting`. - Implement `MainModuleInitializer` using `androidx.startup` to load Koin modules. - Add `MainViewModel` to manage app state during the splash screen transition. - Update `libs/navigation` and `feature/onboarding/api` to use `api` configuration for navigation dependencies. - Define `mainModule` for Android-specific dependency injection.
- Implement `NavDisplay` in `App.kt` using `koinEntryProvider` and standard entry decorators. - Add `koin-compose-navigation3` dependency to `composeApp` and `feature:onboarding:api`. - Refactor `MainViewModel` to resolve the `startDestination` flow based on `AppState`. - Update `MainActivity` to handle initial navigation via `LaunchedEffect` and the `Navigator` singleton. - Simplify `Navigator` by removing `replaceRootDestination` and initializing with an empty backstack. - Remove unused `RootDestination` from `AppRoute`.
…forcement - Rename `:feature:onboarding:impl` to `:feature:onboarding:android` and convert it to a standard Android library. - Add `AndroidLibraryConventionPlugin` to handle common Android library configurations. - Implement `enforceInternalModuleBoundaries` logic to restrict access to `:impl` and `:android` modules. - Update Koin initialization to use the new onboarding Android module. - Clean up dependencies in onboarding API and aggregate modules.
…ides * Revise `:feature` module structure to include `:api`, optional `:impl`, and `:android` (pure Android) modules. * Update parent proxy module pattern to focus on transitively re-exporting `:api` without hosting source code or aggregated Koin modules. * Centralize Koin DI composition in `:libs:di`, referencing platform-specific and common modules directly instead of using per-feature aggregators. * Document `ModuleBoundaryEnforcement` rules for internal module dependencies. * Update step-by-step feature creation and Koin wiring checklists to reflect the new architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.