Add native skeletal asset structural diffs - #898
Draft
vaughn1990 wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
diff_assetbridge handler to compare exactUSkeletonandUSkeletalMeshassets.Why
Issue #879 had to load mannequin SkeletalMesh assets through
execute_pythonand manually compare hundreds of bone entries. This adds the compact native bridge operation needed to answer that structural compatibility question without custom Python or full bone dumps.This PR is intentionally scoped to
plugin/ue_mcp_bridge. The server-sideasset(diff)description can be updated separately to advertise the newly supported classes.Addresses #879.
Safety
Validation
npx.cmd tsc --noEmitnpm.cmd run test:unit— 83 files / 840 tests passednpm.cmd run audit:unitygit diff --check upstream/main...HEADThe guarded native build was attempted against the bundled
tests/ue_mcpproject with-NoEngineChanges. UnrealBuildTool stopped before compilation because the selected source engine's newerBuild.versionwould rewrite existing engine binaries/module manifests. The guard was not bypassed.Full
npm run auditstill reports unrelated baseline drift inasset.migratedocumentation parameters and existing handler/caller inventory; focused unity and TypeScript/unit checks pass.