Skip to content

ENHANCED: Start Inlay at login by default - #39

Merged
bmdavis419 merged 1 commit into
davis7dotsh:mainfrom
saphid:t3code/launch-at-login-default
Oct 30, 2026
Merged

bmdavis419 merged 1 commit into
davis7dotsh:mainfrom
saphid:t3code/launch-at-login-default

Conversation

@saphid

@saphid saphid commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

"Start Inlay at login" was off by default, so a new install didn't come back after a restart until you went and found the toggle. It's now on by default.

The default flips in InlayConfiguration (initializer and decoder fallback) and in the controller's initial value. Configs that already store launchAtLogin keep that value. Only fresh configs, or ones missing the key, pick up the new default.

Proof: ran Inlay Dev against an empty INLAY_CLIENT_DATA_DIR. It wrote "launchAtLogin" : true and sfltool dumpbtm showed the Inlay Dev login item as enabled. Relaunching with an explicit false flipped it to disabled. bun run check, lint, fmt:check and swift build pass.

Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

No merge-blocking issues identified; the changed defaults preserve saved choices and the existing startup registration path.

Summary

Enables “Start Inlay at login” by default.

  • Fresh Inlay setups add the app to login items by default.

T-Rex validation blocked

Native startup and login-item registration could not be verified on this Linux host. The development app build stopped with “The desktop client requires macOS”; Swift, Xcode, xcrun, and sfltool are unavailable.

Reviews (1) · Last reviewed commit: "ENHANCED: Start Inlay at login by defaul..." · Reviewed by Greptile

New installs now register Inlay as a login item unless the user turns it
off. Existing config files keep their stored choice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The controller and configuration now default launch at login to enabled. Decoding uses enabled as the fallback when stored configuration omits the setting. Explicit stored values remain unchanged.

Changes: Launch at Login Defaults

Layer / File(s) Summary
Launch-at-login defaults
Sources/InlayCore/InlayConfiguration.swift, Sources/Inlay/InlayController.swift
The configuration initializer and decoding fallback now use true for launchAtLogin. The controller also initializes the setting to true.

Suggested reviewers: bmdavis419

Priority: Low

Merge Risk: Minimal · up to 679b8

The intended default change is internally consistent and ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: enabling Inlay to start at login by default.
Description check Passed The description is directly related to the changeset. It explains the new default, preserved stored values, affected files, and reported validation.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bmdavis419
bmdavis419 merged commit 7ffe640 into davis7dotsh:main Oct 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants