Repository navigation
fix: point demo card links to valid storybook stories - #919
Merged
davidhu2000 merged 1 commit intoSep 28, 2026
Merged
Conversation
davidhu2000
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are introduced?
The loader name links on the demo page pointed to
storybook?path=/docs/<name>--docs, which doesn't resolve. No docs pages exist: the stories come fromscripts/stories.template, which exports onlyPrimaryand has noautodocstag.The links now go to
storybook/?path=/story/<name>--primary, which matches the live Storybook URLs (e.g. https://www.davidhu.io/react-spinners/storybook/?path=/story/clockloader--primary).vite.config.mjs: fix the link in the static loader cards generated intoindex.htmlexamples/components/SpinnerCard.tsx: fix the link in the React-rendered cardsAny screenshots?
before link:
https://www.davidhu.io/react-spinners/storybook?path=/docs/circleloader--docsafter link:
https://www.davidhu.io/react-spinners/storybook/?path=/story/circleloader--primary