Repository navigation
feat: keep footer at bottom when search has no results - #917
Merged
davidhu2000 merged 1 commit intoSep 28, 2026
Merged
Conversation
davidhu2000
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are introduced?
When a search returns no loaders, the grid collapses to the short "empty" message and the page ends up shorter than the window. The footer then sits right under the content instead of at the bottom.
bodyis now a vertical flex column that's at least as tall as the window (min-height: 100vh, or100dvhwhere supported).maingetsflex: 1so it fills the leftover space and pushes the footer down.mainalso getswidth: 100%, because a flex item otherwise shrinks to fit its content and would get narrower when the grid is empty.The sticky topbar still works, since the flex column doesn't affect
position: sticky.Any screenshots?
before:
after: