Skip to content

Exception with optional dependencies not met #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daumiller merged 2 commits into from
Mar 17, 2016
Merged

Exception with optional dependencies not met #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
690a902
Add try/catch blocks and promise rejection for the database clients
chaosfinity Mar 3, 2016
60333ab
Ensure handled error is only missing module error throw any others
chaosfinity Mar 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions lib/db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,35 @@
var NeDbClient = require('./clients/nedbclient');
var MongoClient = require('./clients/mongoclient');
try {
var NeDbClient = require('./clients/nedbclient');
} catch (e) {
if(e.code !== 'MODULE_NOT_FOUND') {
throw e;
}
var NeDbClient = null;
}

try {
var MongoClient = require('./clients/mongoclient');
} catch (e) {
if(e.code !== 'MODULE_NOT_FOUND') {
throw e;
}
var MongoClient = null;
}

exports.connect = function(url, options) {
if (url.indexOf('nedb://') > -1) {
if(NeDbClient === null) {
return Promise.reject(new Error('The NeDB dependency has not been met'));
}
// url example: nedb://path/to/file/folder
return NeDbClient.connect(url, options).then(function(db) {
global.CLIENT = db;
return db;
});
} else if(url.indexOf('mongodb://') > -1) {
if(MongoClient === null) {
return Promise.reject(new Error('The MongoDB dependency has not been met'));
}
// url example: 'mongodb://localhost:27017/myproject'
return MongoClient.connect(url, options).then(function(db) {
global.CLIENT = db;
Expand All @@ -17,4 +38,4 @@ exports.connect = function(url, options) {
} else {
return Promise.reject(new Error('Unrecognized DB connection url.'));
}
};
};